Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1824 pb2nc log message for mlcape #2089

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Mar 7, 2022

Expected Differences

The log message: The number of derived CAPE includes the MLCAPE. They are separated

DEBUG 3: Derived CAPE = 368 Zero = 146
DEBUG 3:        not derived: No cape inputs = 189       No vertical levels = 19664
DEBUG 3:        filtered: 0, 0

==>

DEBUG 3: Derived CAPE = 184     Zero = 62
DEBUG 3:        not derived: No cape inputs = 189       No vertical levels = 19664
DEBUG 3:        filtered: 0, 0
DEBUG 3:
DEBUG 3: Derived MLCAPE = 184   Zero = 84
DEBUG 3:        not derived: No cape inputs = 189       No vertical levels = 19664
DEBUG 3:        filtered: 0, 0
  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

/d1/personal/hsoh/git/features/feature_1824_pb2nc_MLCAPE3/MET/met/bin/pb2nc /d1/personal/hsoh/data/CAPE_data/prepda.2018091100 ./prepda.2018091100.add_cape.nc /d1/personal/hsoh/data/config/PB2NCConfig_cal_cape -v 3 -nmsg 10%

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 10.1.0 milestone Mar 7, 2022
@hsoh-u hsoh-u added this to Review in progress in MET-10.1.0-rc1 (3/10/22) via automation Mar 7, 2022
@hsoh-u hsoh-u changed the title Feature 1824 pb2nc mlcape3 Feature 1824 pb2nc log message for mlcape Mar 7, 2022
@JohnHalleyGotway JohnHalleyGotway linked an issue Mar 7, 2022 that may be closed by this pull request
21 tasks
MET-10.1.0-rc1 (3/10/22) automation moved this from Review in progress to Reviewer approved Mar 8, 2022
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this PR. I confirmed that the GHA testing workflow flagged no differences. I reviewed the code changes and see the requested change to the log message in pb2nc.cc but do also see changes to 3 other files. I assume those changes are to satisfy issues raised by SonarQube scans.

Thanks for enhancing the logging.

@hsoh-u hsoh-u merged commit 1b9784e into develop Mar 8, 2022
MET-10.1.0-rc1 (3/10/22) automation moved this from Reviewer approved to Done Mar 8, 2022
@hsoh-u hsoh-u deleted the feature_1824_pb2nc_MLCAPE3 branch March 8, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Enhance PB2NC to derive Mixed-Layer CAPE (MLCAPE).
2 participants