Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2115 main_v10.1 Rotated LatLon #2116

Merged
merged 2 commits into from Apr 1, 2022

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Confirmed that plot_data_plane now plots the rotated lat/lon data over the UK in the proper location. Also confirmed that the rotated lat/lon India test data produces that same result as before.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Could retrieve prods_op_ukv_rotated_latlon_20220301_00_000.nc and run:

plot_data_plane prods_op_ukv_rotated_latlon_20220301_00_000.nc plot.ps 'name="surface_altitude"; level="(*,*)";'

And confirm that the data aligns with the map.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    None needed.

  • Do these changes include sufficient testing updates? [No]
    No change in this PR but I added a new unit test for the develop branch.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [4/1/22].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…he north pole location when instantiating rotated lat/lon grids from CF-compliant NetCDF files.
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the file that changed. I retrieved the prods_op_ukv_rotated_latlon_20220301_00_000.nc file and ran the plot_data_plane command to confirm that the data aligns with the map. I approve this pull request.

@JohnHalleyGotway JohnHalleyGotway merged commit 71f3d42 into main_v10.1 Apr 1, 2022
@JohnHalleyGotway JohnHalleyGotway deleted the bugfix_2115_main_v10.1_rotll branch April 8, 2022 18:13
jprestop added a commit that referenced this pull request May 19, 2022
* added logic to manually trigger a workflow via the GitHub… (#2107)

* Bugfix #2102 main_v10.1 initialize modified_hdr_typ (#2108)

* Bugfix #2115 main_v10.1 Rotated LatLon (#2116)

* Per #2123, added debug code to make this error that was unrepoducible, reproducible on seneca. Just initialize the newly allocated time_values array with values of -10. PLEASE REMOVE THAT TEST CODE PRIOR TO SUBMITTING A PR TO FIX THIS ISSUE.

* #2123 Initialize ValidTime if afile to read time bvariable

* #2123 Support int64 data type

* #2123 Support int64 data type

* Bugfix #2118 main_v10.1 grib1_rotll (#2129)

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>

* Bugfix #2106 main_v10.1 gcc (#2134)

* Feature 2141 v10.1.1 (#2144)

* Add testing and docs badges.

* #14 Using literal instead of numbers and make sure no overflow

* #14 Using literal instead of numbers

* #14 Added tmp_buf_size

* #14 Define n_kw_infos first

* #14 Using literal instead of numbers

* Bugfix #2148 main_v10.1 misses (#2149)

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>

* dtcenter/METplus-Internal#14 formatting code

* Feature 2162 v10.1.2 (#2163)

* Per #2162, update versions and notes for the 10.1.2 bugfix release

* Per #2162, update versions and notes for the 10.1.2 bugfix release

* Per #2162, fixing syntax error

* Add "METplus-Internal" before the issue number for clarity

Co-authored-by: johnhg <johnhg@ucar.edu>

Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: johnhg <johnhg@ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Fix support for reading rotated lat/lon grids from CF-compliant NetCDF files
2 participants