Update develop-ref after #2165 #2167

JohnHalleyGotway · 2022-05-20T23:15:34Z

Expected Differences

PR #2165 for issue #2072 modifies the output of 2 TCRMW NetCDF output files. The differences shown below, adding new output for VR and VT are fully expected:

COMPARING tc_rmw/tc_rmw_hwrf_gonzalo.nc
file1: /data/output/met_test_truth/tc_rmw/tc_rmw_hwrf_gonzalo.nc
file2: /data/output/met_test_output/tc_rmw/tc_rmw_hwrf_gonzalo.nc
ERROR: NetCDF headers differ:

COMPARING tc_rmw/tc_rmw_pressure_lev_out.nc
file1: /data/output/met_test_truth/tc_rmw/tc_rmw_pressure_lev_out.nc
file2: /data/output/met_test_output/tc_rmw/tc_rmw_pressure_lev_out.nc
ERROR: NetCDF headers differ:

> 	double VR(range, azimuth, pressure, track_point) ;
> 		VR:long_name = "Radial Velocity" ;
> 		VR:units = "m/s" ;
> 		VR:_FillValue = -9999. ;
> 	double VT(range, azimuth, pressure, track_point) ;
> 		VT:long_name = "Tangential Velocity" ;
> 		VT:units = "m/s" ;
> 		VT:_FillValue = -9999. ;

Updating develop-ref to get past these diffs.

…tead of only the filename so that the function can tell whether or not the file exists. (#1952) Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>

* Per issue #1761 in set_perc() adding code to get FBIAS numeric value, like 1.0 or 0.9, etc. SL * Per issue #1761: in set_perc(), modified actual percentile calculation at end to use the extracted FBIAS numeric value (float). SL * Per issue #1761: modified the check on the perc_thresh_freq_bias, just has to be > 0 now. SL * Per issue #1761: cleaned up code in set_perc(). SL * Per #1761, updates to Simple_Node::set_perc() to handle variable frequency bias amounts. Changes include: - Reverting the formatting of this back to how it originally was in the develop branch. In general, just match the formatting of the existing file, so as the minimize the number of difference lines. - Add logic to adjust the percentile to be found based on the requested FBIAS value. Multiplying or dividing the percentile by the FBIAS value depends on the inequality type and whether we're bias adjusting the forecast or observation data. - Adjust the log messages slightly. Please be aware that I'm not totally confident in these changes. They warrant much more testing. This logic is very, very confusing. * Per #1761, call compute_percentile() when double-checking the percentile values. * Per #1761, remove unused variable. * Per #1761, add warning for percentiles > 100. * Per #1761. In set_perc(), after testing cleaned up code. SL * Per issue #1761: adding new config file for testing dynamic FBIAS values. SL * Per issue #1761: added new unit test for dynamic FBIAS values when running grid_stat. SL * Per issue #1761, modified FBIAS section to indicated that the user can use dynamic values that are not 1.0. SL * Update met/docs/Users_Guide/config_options.rst Co-authored-by: johnhg <johnhg@ucar.edu> * Update met/docs/Users_Guide/config_options.rst Co-authored-by: johnhg <johnhg@ucar.edu> * Update met/docs/Users_Guide/config_options.rst Co-authored-by: johnhg <johnhg@ucar.edu> * Update test/config/GridStatConfig_fbias_perc_thresh Co-authored-by: johnhg <johnhg@ucar.edu> * Update test/config/GridStatConfig_fbias_perc_thresh Co-authored-by: johnhg <johnhg@ucar.edu> * Update test/config/GridStatConfig_fbias_perc_thresh Co-authored-by: johnhg <johnhg@ucar.edu> * Update test/config/GridStatConfig_fbias_perc_thresh Co-authored-by: johnhg <johnhg@ucar.edu> * Per issue #1761, set nc_pairs_flag = FALSE. SL Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>

…d output files.

…ing the logic for computing the ensemble range back to what it was previously. The new version produced very slight differences in the 6-th or 7-th decimal place when compared to previous results. There's not good reason for these changes which were caused by the order of operations in casting from doubles to floats. Reverting back to the old logic prevents diffs for anyone else downstream and is the prudent choice.

* #1949 Added CF compliant NetCDF into data IO * #1949 Added commas * #1948 Some corrections for typo and added the links for CF attributes * #1948 Added Performance with NetCDF input data * #1949 Corrected tyoe and applied Juloie's suggestions Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>

…OSS. The intel compiler does not allow adjacent >> characters when defining maps.

…elease needs to be recreated.

… required variables for MESONET

…p branch as well.

…... updating the develop branch.

Bugfix 1936 develop madis2nc

…ntdata_python

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu>

Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: Randy Bullock <bullock@seneca.rap.ucar.edu> Co-authored-by: davidfillmore <fillmore.winslow.david@gmail.com> Co-authored-by: rgbullock <bullock@ucar.edu> Co-authored-by: Seth Linden <linden@ucar.edu> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: John Halley Gotway <johnhg@seneca.rap.ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> Co-authored-by: mo-mglover <78152252+mo-mglover@users.noreply.github.com> Co-authored-by: davidalbo <dave@ucar.edu> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com> Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu>

… variable-length strings passed to ascii2nc.

Feature dtcenter/METplus-Internal#14 fixed length array

…t causes the nightly build to fail.

* bug fix for NAN and for using missing data as if its not missing * added parameters to control converting winds to tangential/radial components * bug fixes * Refactored to put wind conversion into it's own class TCRMW_WindConverter * changed default for converting winds to TRUE, and put parameters for wind conversion into the unit test config files * Per #2072, updating tc_rmw Makefile.in to compile new files. * Per #2072, update to the output from the lex/yacc version on seneca. * Changed Error to Warning in mlog messages, for consistency with MET conventions * Removing commented out code. * Per #2072, combine warnings spread across multiple lines into a single call to the logger. Replace references to ugrid/vgrid with u/v wind. Fix a typo and clean up some whitespace. Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

jprestop and others added 30 commits October 26, 2021 13:08

Per #1906, modify code to pass entire path to make_temp_file_name ins…

9437447

…tead of only the filename so that the function can tell whether or not the file exists. (#1952) Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>

Feature 1905 ens_ctrl (#1955)

d60924c

Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>

Hotfix after merging changing for #1761. Updating the list of expecte…

3b13ce1

…d output files.

Feature 1957 ascii2nc_python (#1958)

4ff28d1

Feature 1968 ens_ctrl (#1969)

867360f

Feature 1809 gen prob (#1967)

0990061

Merge branch 'develop-ref' into develop

1663bb6

Feature 1970 v10.1.0-beta4 (#1973)

13996c2

Fix tiny typo in plot_data_plane usage statement.

dae9db7

Hotfix for the develop branch to get met-10.1.0-beta4 compiling on WC…

9bd9946

…OSS. The intel compiler does not allow adjacent >> characters when defining maps.

Updating the beta4 release date from 11/16 to 11/17 since the beta4 r…

e0b659d

…elease needs to be recreated.

Update the MET PR template to list expected changes up front.

817d9db

Bugfix 1976 develop cdist (#1979)

4e28ae7

Merge branch 'develop-ref' into develop

6d16e23

#1936 Excludes precip3hr, precip6hr, precip12hr, and precip10min from…

39a5233

… required variables for MESONET

Per #1985, correcting typo found while creating V10.0.1 in the develo…

c9434e8

…p branch as well.

Per #1985, VERY minor change to fix alignment of titles in Point-Stat…

84f8c7f

…... updating the develop branch.

#1936 Added an unit test for newer MESONET file

d35190e

Merge pull request #1984 from dtcenter/feature_1936_madis_nc2

f81d250

Bugfix 1936 develop madis2nc

Feature 1989 sort (#1990)

8c29f09

Feature 1991 VCNT (#1992)

b93f4ea

Feature 1993 grid_mask (#1994)

49fb555

#1844 Added vx_pointdata_python

dd0a68b

#1844 Added vx_pointdata_python to PYTHON_LIBS & make file for vx_poi…

2b61506

…ntdata_python

#1844 Added vx_pointdata_python to SUBDIRS

b4a4e18

#1844 Initial release

ba9f81e

#1844 Added met_point_data.cc & met_point_data.h

abef2b7

JohnHalleyGotway and others added 28 commits April 8, 2022 13:16

Bugfix #2118 develop grib1_rotll (#2130)

1e1a4cc

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>

Bugfix 2123 nccf valid time (#2127)

a80097b

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu>

Merge remote-tracking branch 'origin/develop-ref' into develop

6447251

Feature #2132 version 11.0.0 (#2133)

2e53ff7

Doc-only update to expliciltly list the maximum character lengths for…

5ecbf56

… variable-length strings passed to ascii2nc.

Added pcp_combine -subtract example (#2153)

15ca7c3

Add testing and docs status badges.

8f1ce80

Feature #2152 poly_xy (#2154)

7427450

#14 Using literal instead of numbers and make sure no overflow

e6f5068

#14 Using literal instead of numbers

81fe0a4

#14 Added tmp_buf_size

e3fbfdf

#14 Define n_kw_infos first

d56db12

#14 Using literal instead of numbers

ba05032

Bugfix #2148 develop misses (#2150)

75061c2

Merge branch 'develop-ref' into develop

6debf03

dtcenter/METplus-Internal#14 formatting code

ac50028

Merge pull request #2157 from dtcenter/feature_14_fixed_length_array

aa23fda

Feature dtcenter/METplus-Internal#14 fixed length array

changing 'Linked issue' to 'Development issue'

32f6ac3

change Linked issue/Development issue ci-skip-all

d77e759

change Linked issue/Development issue ci-skip-all

b93c935

change Linked issue/Development issue ci-skip-all

7fe963d

Feature 1920 repo (#2161)

83bcd89

List line types that can be aggregated per dtcenter/METplus#1625

3c4a124

Merge branch 'develop-ref' into develop

b7b0861

Hotfix for the develop branch to correct a bad MET_TEST_BASE path tha…

4a0ca2b

…t causes the nightly build to fail.

Merge branch 'develop-ref' into develop

4a754ea

JohnHalleyGotway added this to the MET 11.0.0 milestone May 20, 2022

JohnHalleyGotway merged commit c5ea4c8 into develop-ref May 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update develop-ref after #2165 #2167

Update develop-ref after #2165 #2167

JohnHalleyGotway commented May 20, 2022 •

edited

Update develop-ref after #2165 #2167

Update develop-ref after #2165 #2167

Conversation

JohnHalleyGotway commented May 20, 2022 • edited

Expected Differences

JohnHalleyGotway commented May 20, 2022 •

edited