Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2173 main_v10.1 shift_data_plane #2174

Merged

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Jun 7, 2022

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Manually ran 2 calls to shift_data_plane to confirm that they now work after this change:
bin/shift_data_plane PYTHON_NUMPY out.nc \
'name="scripts/python/read_ascii_numpy.py data/python/fcst.txt FCST";' \
-from 30 -110 -to 35 -115

and

bin/shift_data_plane data/python/fcst.txt out.nc \
'name="scripts/python/read_ascii_numpy.py MET_PYTHON_INPUT_ARG FCST"; file_type=PYTHON_NUMPY;' \
-from 30 -110 -to 35 -115

Produce this shifted output:
Screen Shot 2022-06-07 at 11 50 05 AM

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the code changes. Also review the companion PR for the develop branch which will include updates to the unit tests.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
    No doc changes included or needed.

  • Do these changes include sufficient testing updates? [No]
    No testing changes included or needed. Will update the unit tests for the develop branch.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fri 6/10/22].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…ile::data_plane() which supports the common python embedding logic. Calling Met2dDataFile::open() first prevents the logic from working.
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.1.3 (bugfix) milestone Jun 7, 2022
@JohnHalleyGotway JohnHalleyGotway linked an issue Jun 7, 2022 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes and have ensured that these are the same changes as in the develop branch. I looked at the additions to unit_python.xml for the develop branch PR #2175, confirmed they're the same as listed in the issue #2173, and confirmed that GHA successfully runs them. As expected, the only diff is the addition of two new output files from shift_data_plane. I approve this pull request.

@JohnHalleyGotway JohnHalleyGotway merged commit d2379e8 into main_v10.1 Jun 7, 2022
@JohnHalleyGotway JohnHalleyGotway deleted the bugfix_2173_main_v10.1_shift_data_plane branch June 7, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Fix support for python embedding in shift_data_plane
2 participants