Feature 2250 accum #2251
Merged
Feature 2250 accum #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time attribute is present, report the value as 0 instead of bad data.
22 tasks
jprestop
approved these changes
Sep 1, 2022
georgemccabe
added a commit
to dtcenter/METplus
that referenced
this pull request
Sep 6, 2022
georgemccabe
added a commit
to dtcenter/METplus
that referenced
this pull request
Sep 6, 2022
Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: Mrinal Biswas <biswas@seneca.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Mrinal Biswas <biswas@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: j-opatz <jopatz@ucar.edu> Co-authored-by: Kathryn Newman <knewman@seneca.rap.ucar.edu> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Co-authored-by: Lisa Goodrich <lisag@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: Christina Kalb <kalb@mohawk.rap.ucar.edu> Co-authored-by: Christina Kalb <kalb@ucar.edu> Co-authored-by: Hank Fisher <fisherh@ucar.edu> Co-authored-by: mrinalbiswas <biswas@ucar.edu> Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: Molly Smith <molly.b.smith@noaa.gov> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: bikegeek <minnawin@ucar.edu>
JohnHalleyGotway
added a commit
that referenced
this pull request
Nov 3, 2022
* Initialze obs_data at constructor to avoid warninjg on building * Initialze obs_data at constructor to avoid a warning by compiler * #1824 ci-run-test Removed the duplicated code * Feature 1810 expand asciitable (#2086) * Feature 1583 skip_mean (#2090) * Feature 1275 MODE Object Count (#2091) * for #1275, fix issue with more than 1000 object for mode, ci-run-unit * Per #1275, just deleting stale, commented-out code. Co-authored-by: Randy Bullock <bullock@seneca.rap.ucar.edu> * Feature 1184 dryline (#2088) Co-authored-by: davidfillmore <fillmore.winslow.david@gmail.com> Co-authored-by: rgbullock <bullock@ucar.edu> Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu> * Feature 1184 replace_env (#2093) * Feature 2092 v10.1.0-rc1 (#2094) * Hotfix to the develop branch to fix the MODE Makefile for the MET-10.1.0-rc1 release. * Second hotfix for the MODE Makefile in the develop branch. * Feature 1844 docs (#2096) * Feature 2097 v10.1.0 (#2099) * Feature 2098 gen ens prod doc (#2100) * update job control rules for GHA testing workflow to use version specific input data if running tests on main_v branch * Migrating a small tweak added to the v10.1.0 release into the develop branch. * Adding SonarQube location to development.seneca file. * Bugfix #2102 develop initialize modified_hdr_typ (#2104) Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> * added logic to manually trigger a workflow via the GitHub… (develop) (#2109) Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Feature update installation info (#2114) * Updating configuration and modulefiles * Removed jet files * create DockerHub tag that ends with -lite to use when triggering the METplus testing workflow * Bugfix #2115 develop Rotated LatLon (#2117) * Feature 1950 sort station list (#2121) * Update the top-level README file to list ioda2nc, but also to trigger GHA to run for this new main_v10.1-ref branch. * Added bool Sorted variable, set to true or false in relevant functions. Updated sort() function. SL * In parse_sid_mask(), added the line: mask_sid.sort(). SL * Per issue #1950, put in some cout statements for testing. SL * Per issue #1950, working in has() function, checking for Sort and put in initial cout's for testing. SL * Per issue #1950: Cleaned up some cout (print) statements. Left one in there that is commented out for future testing. SL * Per issue #1950: modified has() function. Added lower_bound search for sorted arrays. Left some print (cout) statements in there for further testing. SL * Per issue #1950: In has(), I commented out the print (cout) statements for time testing. SL * added logic to manually trigger a workflow via the GitHub… (#2107) * Per issue #1950, put back in some print (cout) statements for testing. SL * Per issue #1950: in has() function, experimenting using the upper_bound() search instead of lower_bound() for sorted vectors. In progress. SL * Per issue #1950: added a new has function that uses binary_search. Re-working the other has() functions related to this. SL * Per issue #1950: re-worked original has(), basically reverted back to what it was...but it's now only used for unsorted vectors or for a case insensitive search. Cleaned up. SL * Per issue #1950: in section that checks Obs Station Id in SID masking list, changed cout to a mlog (debug) statement. SL * Per issue #1950: created new mask station id list (CONUS METARs) and modified the PointStatConfig_MASK_SID config file to use this list along with the existing lists. SL * Per issue #1950: reverted back to orginal sid mask site-lists. SL * Per issue #1950: checking in this site-list that was used for testing point_stat. SL * Per issue #1950, modified and added better debugging to figure out current issue with ascii2nc. SL * Per #1950, small tweak in ascii2nc to make it slightly more efficient. After adding the new obs varable name to the end of the list, we can compute var_index direclty without needing to call StringArray::has() a second time. * Per #1950: removed mlog and cout print statements from has() functions. Cleaned up. SL * Update met/src/basic/vx_log/string_array.cc Co-authored-by: johnhg <johnhg@ucar.edu> * Update met/src/basic/vx_log/string_array.cc Co-authored-by: johnhg <johnhg@ucar.edu> * Update met/src/basic/vx_log/string_array.cc Co-authored-by: johnhg <johnhg@ucar.edu> * Update met/src/basic/vx_log/string_array.cc Co-authored-by: johnhg <johnhg@ucar.edu> * Update met/src/basic/vx_log/string_array.cc Co-authored-by: johnhg <johnhg@ucar.edu> * Update met/src/basic/vx_log/string_array.h Co-authored-by: johnhg <johnhg@ucar.edu> * Delete SID_CONUS.txt * Delete SID_CONUS_times11.txt Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Bugfix #2118 develop grib1_rotll (#2130) Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Bugfix 2123 nccf valid time (#2127) Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> * Feature #2132 version 11.0.0 (#2133) * Bugfix #2106 develop gcc (#2135) Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: Randy Bullock <bullock@seneca.rap.ucar.edu> Co-authored-by: davidfillmore <fillmore.winslow.david@gmail.com> Co-authored-by: rgbullock <bullock@ucar.edu> Co-authored-by: Seth Linden <linden@ucar.edu> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: John Halley Gotway <johnhg@seneca.rap.ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> Co-authored-by: mo-mglover <78152252+mo-mglover@users.noreply.github.com> Co-authored-by: davidalbo <dave@ucar.edu> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com> Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu> * Doc-only update to expliciltly list the maximum character lengths for variable-length strings passed to ascii2nc. * Added pcp_combine -subtract example (#2153) * Add testing and docs status badges. * Feature #2152 poly_xy (#2154) * #14 Using literal instead of numbers and make sure no overflow * #14 Using literal instead of numbers * #14 Added tmp_buf_size * #14 Define n_kw_infos first * #14 Using literal instead of numbers * Bugfix #2148 develop misses (#2150) * dtcenter/METplus-Internal#14 formatting code * METplus-Internal #16 Added python scanning * METplus-Internal #16 changed name * METplus-Internal #16 initial release for python scanning * METplus-Internalv#19 added maic.cc & main.h * METplus-Internalv#19 renamed main to met_main and added get_tool_name * METplus-Internalv#19 Initial release * changing 'Linked issue' to 'Development issue' * change Linked issue/Development issue ci-skip-all * change Linked issue/Development issue ci-skip-all * change Linked issue/Development issue ci-skip-all * Feature 1920 repo (#2161) * List line types that can be aggregated per dtcenter/METplus#1625 * Hotfix for the develop branch to correct a bad MET_TEST_BASE path that causes the nightly build to fail. * Feature 2072 tc rmw winds (#2165) * bug fix for NAN and for using missing data as if its not missing * added parameters to control converting winds to tangential/radial components * bug fixes * Refactored to put wind conversion into it's own class TCRMW_WindConverter * changed default for converting winds to TRUE, and put parameters for wind conversion into the unit test config files * Per #2072, updating tc_rmw Makefile.in to compile new files. * Per #2072, update to the output from the lex/yacc version on seneca. * Changed Error to Warning in mlog messages, for consistency with MET conventions * Removing commented out code. * Per #2072, combine warnings spread across multiple lines into a single call to the logger. Replace references to ugrid/vgrid with u/v wind. Fix a typo and clean up some whitespace. Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * change Linked issue/Development issue ci-skip-all * Bugfix #2173 develop shift_data_plane (#2175) * Bugfix #2170 develop agg_ecnt (#2177) * Feature 2022 anom corr to vcnt (#2171) * Per #2022: Added ANOM_CORR, ANOM_CORR_BCL, ANOM_CORR_BCU to vcnt_columns. SL * Per #2022: Added ANOM_CORR, ANOM_CORR_BCL, ANOM_CORR_BCU to write_vcnt_cols. SL * Per #2022: Added ANOM_CORR to VL1L2Info. SL * Per #2022: updated the VL1L2Info functions to initialize and compute ANOM_CORR. SL * Per #2022: in calc_ncep_stats modified calculation for ANOM_CORR to check for bad data in the denominator first. SL * Per #2022: for the VL1L2Info, changed all derived VCNT variables to be CIInfo objects (instead of doubles). SL * Per #2022: making changes to VL1L2Info related to making all VCTN variables CIInfo objects. In progress. SL * Per #2022: Added ANOM_CORR_UNCNTR. SL * Per issue 2022: Modified functions in the VL1L2Info class to set the NCEP stat variables correctly since they are now CIInfo class memembers. SL * Per issue 2022: Added ANOM_CORR_UNCNTR (_BCL, _BCU). SL * Per issue 2022: modified write_vcnt_cols(), added ANOM_CORR_UNCNTR (_BCL, _BCU). SL * Per issue #2022: updated write_vcnt_cols. VCNT variables are now CIInfo objects to have to .v for the value. SL * Per issue #2022: In calc_ncep_stats, put in place-holder for ANOM_CORR.v value SL * Per issue #2022: in calc_ncep_stats(), changed placeholder for ANOM_CORR. SL * Per issue #2022: moved alpha initialization to the init_from_scratch() function. SL * Per issue #2022: in calc_ncep_stats(), set ANOM_CORR to bad_data_double as a placeholder for now. SL * Per issue #2022: in vcnt_cols(), added ANOM_CORR_NCL/NCU. SL * Per issue #2022: in write_vcnt_cols(), added ANOM_CORR_NCL/NCU variables. SL * Per #2022, adding new VCNT columns to the header table files, User's Guide documentation, and lining some code up more consistently. * Per #2022, added FA_SPEED_BAR and OA_SPEEED_BAR to the VAL1L2 line type. Added code to compute the ANOM_CORR confidence interval. However, I still need to update the writing of the VCNT line type to set the alpha value and actually write the computed CI's. * Per #2022, update the writing of the VCNT output line to write the alpha value and anomaly correlation CI's. * Per #2022, update point_stat and grid_stat to allocate alpha values for VL1L2Info objects to store CI's. * Per #2022, call VL1L2Info::zero_out() instead of clear() so that we don't throw away allocated alpha values. * Per #2022, update the Point-Stat and Grid-Stat logic to include the number of alpha values when deciding how many VCNT lines to write. * Per #2022, update the VL1L2Info::operator+= logic to copy over the allocated alpha values. * Per #2022, enhance stat_analysis to support an aggregate_stat job type for VAL1L2->VCNT. This writes ANOM_CORR and ANOM_CORR_UNCNTR output columns. However, there are still things to address. The other stats should be written as NA instead of 0. Recommend changing the VL1L2Info::zero_out() function to intialize stat values to NA instead of 0. Need to update the docs to reflect this support. Also need to actually compute the parametric CI's for ANOM_CORR. Big picture, we should store the VCNT stats in a new VCNTInfo class... just like the SL1L2Info/CNTInfo setup. Storing the sums AND stats in the same VL1L2Info class is unnecessarily confusing. * Per #2022, update Stat-Analysis docs to list VAL1L2 -> VCNT as a supported conversion type. * Per #2022, when computing VL1L2Info CI's, n should be set to vacount rather than the number of input pairs. * Per #2022, add a new call to Stat-Analysis to exercise the VAL1L2 to VCNT conversion. * Per #2022, ci-run-unit fix an aggregation bug in VL1L2Info::operator+=(). * Per issue #2022, added _vcnt.txt output files to check to relevant tests based on if vcnt output file is being generated via the config file. SL Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * #1815 Renamed time_as_offset to Is_offset * #1815 Added vx_data2d_dim_by_value * #1815 Added convert_value_to_offset and renamed _time_dim_offset to _cur_time_index * #1815 Added convert_value_to_offset and renamed _time_dim_offset to _cur_time_index. Support value instead of offset for time and z level * #1815 Support @ for the value insteaed of offset for slicing * #1815 Support value insteaed of offset for slicing * #1815 Deleted unused local variable * #1815 Deleted unused local variable * #1815 Added level by value with @ * #1815 Added plot_data_plane_NCCF_latlon_by_value * #1815 Added level by value with @ * Feature #2180 develop kft (#2181) * dtcenter/METplus-Internal#16 Moved from scripts/sonarqube to internal/scripts/sonarqube * #1815 Updated level * Feature 2022 stat_analysis (#2185) Proceeding with the merge without an external review based on the details listed above. * Feature #2147 HSS (#2169) * #1815 call is_eq to comapre two double values * Per #2147, this is a HOTFIX to the develop branch after PR #2169 added new CTC and CTS columns. Prevoiusly the CTC columns = NBRCTC columns and CTS = NBRCTS. But that is no longer the case. This updates write_nbrctc_cols() and write_nbrcts_cols() to actually write them rather than just calling the functions to write CTC and CTS cols, respectively. * #2187 Added add_offset_att_name & scale_factor_att_name * #2187 Apply add_offse or scale_factor if defined * ##2187 Removed handling add_offset and scale factor. They are applied at the base API * #2187 Changed a log message * Per #2193, add release notes for met-11.0.0-beta1. (#2195) Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> * Hotfix to develop since I forgot to update the version number in conf.py. * #1815 Added more attribute names * #1815 Added get_index_for_dim * #1815 Formatting * #1815 Support a differnt dimension name from thw first data variable * #1815 Use constants for attr names * Hotfix to the develop branch to fix paths in Dockefiles after restructuing the MET repo. * Another hotfix to develop to get the Docker build step working again. The failure from the configure script is caused by the version of the "alocal" executable. The contents of develop are based on seneca, which has: aclocal (GNU automake) 1.16.1 By comparison, my laptop does NOT require that bootstrap be run for: aclocal (GNU automake) 1.16.5 But the Docker image has an older version which triggers the error: aclocal (GNU automake) 1.13.4 Any machine with aclocal 1.16.x works fine. Likely any machine with a version that differs from 1.16.x does not. Running bootstrap fixes that... but also changes the contents of all the Makefile.in files making them appear as a large set of diffs in the repo. This is not an issue inside the docker image since we generally remove the source code after compiling anyway. * Updating the png version of the older flowcharts. * #1815 cleanup * #1815 cleanup * #1851 cleanup * #1851 cleanup * #1815 Added get_att_unixtime * #1851 cleanup * #1815 cleanup * #1815 cleanup * #1815 Support @ for pinterp * #1815 Do not call to_string * #1815 cleanup * Per issue #2081, updated thecontents to match MRMS Version 12.2. Updated existing entries, removed old entries, added new entries. SL (#2199) Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> * #1815 Changed @time to time at plot_data_plane_NCCF_time * Revert "Feature 1815 level value" (#2201) * #1815 Use NcVarInfo members instead API calls * #1815 Added find_var_by_dim_name * #1815 Restored changes for this branch. The changes were reset after revert and merging with latest develop branch * #METplus-Internal_19 cleanup * #METplus-Internal_19 Added more functiofnds and corrected typo * #METplus-Internal_19 Added main.h and main.cc * #METplus-Internal_19 adjusted link order to set oom * #METplus-Internal_19 Renamed main to met_main. Moved oom handler to base API * #METplus-Internal commented out segv_handler which failed to compile at Docker * Fix typo - maintianing * Feature #2204 sum (#2205) * #2202 Added APIs to check the point data (missing data and data types) * #2202 Renamed pointdata_from_xarray to pointdata_from_python_list * #2202 Support python list * #2202 Avoid seg fault by checking point data from python embedding and provides the better log messages * #2202 Support python list * #2202 Added APIs to check the point data (missing data and data types) * #2202 Added APIs to check the point data (missing data and data types) * #2202 Added APIs to check the point data (missing data and data types) * #2202 Added MaskedArray to allowed array data type * Per #2211, enhance warning/error messages when parsing threshold types in dictionary.cc. * #2208 Check existence of ensemble member data before checking bad_data * 2215 Added station_ob to message_type & station_id to station_id for metadata_map * 2215 Add log message for missing message_type and station_id metadata variables. Set NA if a message type is empty string * 2215 Filter out XXX@RecMetaData variables from @metadata variables * Per #2215, update the user's guide to make it consistent with the default ioda2nc config file. * #METplus-Internal_19 Renamed main to met_main and added get_tool_name * Feature sonarqube v11 beta2 (#2222) Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> * Per #2220, update the version number and release notes. * Per #2220, fix typo. * Per #2220, format the METplus-Internal release notes for MET in the same way they were handled for the METplus beta1 release. * Added *hpp * Separated template functions * Separated template functions * Changed argument for get_var_fill_value * Feature 1971 mtd error to warning (#2221) Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * #2225 @Level string is not applied as an index and index string without @ is not applied as value * Feature #2220 v11.0.0-beta2_try2 (#2228) * Updating Hera and Jet files for 11.0.0 release * Adding 11.0.0 modulefiles for Hera and Jet * Updating cheyenne installation files * Reformatted slashes in paths for hera config files * Updating installation files for Orion * Removed beta2 references * Adding configuration and modulefiles for gaea installation * Changing METdatadb references to METdataio * Documentation-only commit directly to develop to correct a typo. The default dotsize if 1.0 rather than 10. * Feature 2055 nbm grib2 update (#2234) * Per issue #2055, in read_grib2_record_list() added new PDS numbers 6, 10, 15 (for NBM data). SL * Per issue #2055: in read_grib2_record_list(), in section that validates PDS number changed, for undefined PDS numbers, changed Error to Warning and continue (instead of exit). SL * Per issue #2055, created new entries for NBM grib2 data fields. SL * Per issue #2055. Added more NBM fields based on a 12z, f003 file. SL * Per issue #2055, after interogating several NBM lead-time files, added TMAX field. SL * Per issue #2055, added grib2_nbm.txt to the list. SL * Per #2055, update the grib2_nbm.txt file entries in the table_files Makefiles. * Per issue #2055, fixed syntax entry for TSTM field. SL * Per issue #2055, fixed a few more syntax errors for some of the fields. SL * Per issue #2055, in read_grib2_record_list(), added section to set level values for template number 6 (NBM data). Also added some temporary print statements. SL * Per issue #2055, in read_grib2_record_list(), added code to set levels for table number 10 (like 6). SL * Per #2055, adding support for new GRIB2_perc_val configuration option to filter records based on the forecast percentile value used by GRIB2 product definition templates 6 and 10. Seth, note that I also included the probability filtering logic tweak we discussed, since it was already present in that same file. * Per issue #2055: in find_record_matches(), in section that resolves Prob fields, changed 'break' to 'continue' for non Probs. SL * Per issue #2055, in read_grib2_record_list() cleaned up some commented out code. SL * Per issue #2055, in read_grib2_record_list() cleaned up all print statements. SL * Per issue #2055, added 5 new unit tests for NBM data. SL * Update data2d_grib2.cc * Update data2d_grib2.cc Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Feature 2207 map (#2241) * Feature #2237 tmp_dir (#2242) * Per #2196, updating files for changes to met base image (#2246) * Hotfix to the develop branch to fix typos in the names of 3 tools (grid_stat, gribtab_dat_to_flat, and gsidens2orank). Also removed commented out code from main.cc. * Feature 2250 accum (#2251) * Feature 2198 zenodo (#2252) * Per #2198, adding Seth Linden and Dave Albo to the Author List * Per #2198, updated Dave Albo to David Albo * Per #2198, added three new authors based on submitted AMS abstract * Per #2198, adding .zenodo.json file * Per #2198, adding orcids for all based on Tatiana's suggestion * Update .zenodo.json Co-authored-by: johnhg <johnhg@ucar.edu> * Update .zenodo.json Co-authored-by: johnhg <johnhg@ucar.edu> * Update .zenodo.json Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> * Per #1744, adding names for rst files in index.rst * Reword to Grid-Stat opening paragraph * Feature 2196 update dockerfile (#2249) * Per #2196, update for upgrade to Python 3.8.6 * Updated based on new structure of METbaseimage * Changed MET_BASE_IMAGE references to MET_BASE_TAG; Added information to the README.md file * Changed MET_BASE_IMAGE references to MET_BASE_TAG; Updated the version from v1.0 to v1.1 * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <johnhg@ucar.edu> * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <johnhg@ucar.edu> * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <johnhg@ucar.edu> * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <johnhg@ucar.edu> * Per #2196, updating README.md based on suggestions from John HG Co-authored-by: johnhg <johnhg@ucar.edu> * Feature 1774 contrib outline (#2253) * creating chapter files * putting a space in to work through the git add and commit process. * Changed formatting of one header Co-authored-by: Lisa Goodrich <lisag@seneca.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> * Fine tune to grid-stat opening paragraph * Feature 2206 fair crps to ecnt (#2247) * Per issue #2206, for the ECNT line type, added CRPS_EMP_FAIR. SL * Per issue #2206, for ECNT line type, added CRPS_EMP_FAIR. SL * Per issue #2206, for ecnt_columns, added CRPS_EMP_FAIR. SL * Per issue #2206, in write_ecnt_cols(), added crps_emp_fair. SL * Per issue #2206, in ECNTInfo, added crps_emp_fair. SL * Per issue #2206, started stubbing code pieced to calculate crps_emp_fair. SL * Per issue #2206, added new function mean_abs_diff(). SL * Per issue #2206, in compute_pair_vals() updated the code to calculate crps_emp and crps_emp_fair. SL * Per issue #2206, added crps_emp_fair (CRPS_EMP_FAIR) to relevant code pieces. SL * Per issue #2206, added wording for CRPS_EMP_FAIR, also added it to last column of ECNT line type. SL * Per issue #2206, added info for CRPS_EMP_FAIR and also added the math equation for this. SL * Per issue #2206, update the math equation for CRPS_EMP_FAIR. SL * Per issue #2206, added new function weighted_mean_absolute_diff(). SL * Per issue #2206, updated the crps_emp_fair calculation to subtract the weighted_mean_abs_diff. SL * Per issue #2206, in aggr_orank_lines(), updated calculation for crps_emp_fair to use weighted_mean_abs_diff. SL * Per issue #2206, renamed weighted_mean_abs_diff() to wmean_abs_diff(). SL * Per issue #2206, for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL * Per issue #2206, in aggr_orank_lines(), for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL * Per issue #2206, updated the math equation for the CRPS_EMP_FAIR calculation. SL * Per issue #2206, fixed a bug in the wmean_abs_diff() function. SL * Per issue #2206, added code for crps_emp_fair. SL * Per issue #2206, in set() function, added checks for crps_emp and crps_emp_fair, for values of 0.0. SL Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> * automated tests: added ability to trigger build of develop-lite docker image that it used in the METplus automated tests * to fix issues with python embedding when the path changes, update development.docker file (apparently unused or rarely previously) to include changes for Python 3.8 including setting the LDFLAG to include -rpath to prevent needing LD_LIBRARY_PATH set to run the tools. Source the env file in the build MET docker script instead of setting the env vars in the configure command * Hotfix to the develop branch to revert the python version from 3.8 back to 3.6. This is done by rolling back the base image in the MET Dockerfiles to dtcenter/met-base:v1.0. Using 3.8 caused the downstream METplus python embedding examples to fail via GHA in the METplus repo. Will write up an issue to investigate more during the MET-11.0.0-beta4 development cycle. * Tweak the build_docker_image.sh script by removing references to MET_BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them. * Revert "Tweak the build_docker_image.sh script by removing references to MET_BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them." This reverts commit 5efc65e. * Hotfix, found 2 more spots where I needed to change v1.1 to v1.0. We should really revisit having this setting spread across so many locations. * Bugfix 2238 link error (#2255) Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> * Feature dtcenter/METplus-Internal#15 add checksum to release (#2254) Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * feature 2216 ioda2nc station_id (#2259) Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Feature 1942 seeps (#2257) Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> * Feature 2142 ascii2nc airnow (#2256) Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Feature 1954 semilatlon (#2262) Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> * Removed future imports since they were used to transition from python 2 to 3. Rearranged logic to be more readible by checking error conditions and exiting if they are not met instead of putting all of the logic to run inside the if statement * Feature 1908 remove ens (#2265) * Feature 2266 v11.0.0-beta3 (#2268) * Minor hotfix for the develop branch. Running bootstrap for develop on seneca changes the order of vx_grid semilatlon slightly. We probably manually editted that file instead of running bootstrap to regenerate it. * Bugfix #2271 develop nbrctc (#2272) Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Feature 2282 docs (#2283) * #2270 Removed version number for SonrQube scanner pathdiff * Feature #2286 grib_lookup (#2288) * Feature 2227 namespace (#2290) * Per #2227 changes in this commit resolve all errors from removing 'using namespace std' from all header files in the src/basic directory * Attempt to resolve errors in GitHub actions from removing 'using namepsace std' from all src/basic/ libraries, plus removal from src/libcode/vx_gnomon/gnomon.h and src/libcode/vx_nc_util/nc_utils.h * Attempt to fix GHA errors with compilation after removal of 'using namespace std'; locally compiles fine * Per #2227, attempting to fix GHA compilation; Compiltion on seneca works fine * Per #2227, attempt to resolve GHA compilation issues; seneca compilation works fine * Per #2227, attempt to resolve GHA compilation issues; seneca compilation works fine * Per #2227, removing namespace from vx_series_data library * Per #2227, removing namespace std from vx_shapedata library * Per #2227, removing namespace std from vx_data2d_grib2 and vx_data2d_grib libraries * Per #2227, removing namespace std from vx_statistics library * Per #2227, removing namespace std from src/tools/tc_utils * Per #2227, removed namespace std from /src/tools/core header files * Per #2227, clean up and continued work * Per #2227, changes to remove namespace std and netCDF from header files * Per #2227, resolve errors in GitHub Actions build * Per #2227, resolve new errors in GitHub Actions build * Per #2227, resolve new errors in GitHub Actions build * Per #2227, resolve new errors in GitHub Actions build * Per #2227, realign variables * Per #2227, updating comment * Per #2227, updating comment * Per #2227, realign variables * Per #2227, realign variables * Per #2227, realign variables * Per #2227, updating comment * Update src/basic/vx_config/config.tab.cc Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> * Feature #2237 test_empty_config (#2291) * Feature #2297 gha (#2299) * GHA hotfix to develop Changes for #2297 included a small typo that I'm fixing directly in the develop branch. * Feature #2297 hotfix to develop A final hotfix to the develop branch to get the build_docker_trigger_metplus.yml workflow working again. I tested on feature_2297_gha branch to confirm that no double-quotes are actually needed. * Update GHA versions * Feature 2281 linker (#2296) Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> * Feature 2036 enhance tc pairs (#2301) Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Feature 2276 enhance ascii2nc to read ndbc buoy data (#2294) Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> * Feature 2155 time units months and years (#2300) Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> * removing release-notes out of overview and creating a seperate chapter for this information. (#2304) * Bugfix #2309 develop tcmpr (#2310) * Bugfix #2306 ascii2nc airnow hourly (#2314) Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu> * Feature #2058 bias_ratio (#2317) * Feature 2232 refine grid diag (#2316) Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> * Feature #392 tcdiag_line_type (#2315) * Feature #2068 ioda2nc v2.0 (#2307) Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> * Feature #2322 v11.0.0-beta4 (#2323) * Feature #2325 ECNT_MAE (#2326) * Hotfix to the develop branch to correct the column numbers in the CNT line type table for the RMSOA, ANOM_CORR_UNCNTR, and SI statistics. * Feature #2332 spread_md (#2333) * Per #2232, add SPREAD_MD to the ECNT line type from Ensemble-Stat and computed for HiRA. * Per #2332, fix compilation error. * Per #2332, update date and release notes for met-11.0.0-beta4. * Per #2332, fix compilation error. Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: Randy Bullock <bullock@seneca.rap.ucar.edu> Co-authored-by: davidfillmore <fillmore.winslow.david@gmail.com> Co-authored-by: rgbullock <bullock@ucar.edu> Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu> Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: Seth Linden <linden@ucar.edu> Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@seneca.rap.ucar.edu> Co-authored-by: mo-mglover <78152252+mo-mglover@users.noreply.github.com> Co-authored-by: davidalbo <dave@ucar.edu> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com> Co-authored-by: Molly Smith <molly.b.smith@noaa.gov> Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu> Co-authored-by: Jonathan Vigh <jvigh@ucar.edu> Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com> Co-authored-by: Lisa Goodrich <lisag@seneca.rap.ucar.edu>
j-opatz
added a commit
to dtcenter/METplus
that referenced
this pull request
Jun 7, 2023
* fixed TCPairs unit tests to handle default value for match_points * bugfix #1691 remove whitespace from output file paths (#1721) * added variables that are needed for use case and were accidentally removed * log error and increment error count if required lat/lon bound variables are not set instad of calling sys.exit * skip metplus_final.conf in check for new output to prevent false alarm diffs * Update index.rst replace METdatadb with METdataio * Update metdatadb.rst Replace metdatadb with metdataio * renamed from metdatadb * replacing all other instances of metdatdb/METdatadb with metdataio/METdataio * after renaming directory from metdatadb to metdataio * replace METdatadb with METdataio * copied and replaced with metdataio filenames * replaced with metdataio version * Update the Release Guide while creating the MET-11.0.0-beta2 development release. Automatic Zenodo updates for each MET release have been DISABLED since they were being created for each development release. Revise the MET instructions to manually update the MET version on Zenodo only for official releases, not development or bugfix releases. * Changed version number * Added release notes * Update the labels scripts by adding 1 new one and renaming metdatadb to metdataio. * updated pandas version used for METdataio use cases to use 1.2.3 instead of 1.4.3 * update version to show development towards beta3 release * Changed METdatadb references to METdataio * Adding modulefiles for installation on various machines. (#1750) * Feature 1746 recreate release (#1751) * Adding instructions for recreating and existing release * Reorder the step's based on suggestions from @georgemccabe * Feature #1489 plot point obs wrapper (#1753) * Fixing typo * Feature #1657 clean up directory creation (#1756) * Feature update labels (#1765) * Modifications for METbaseimage * Update README.md Co-authored-by: johnhg <johnhg@ucar.edu> * feature dtcenter/METplus-Internal#20 add user ID to log output (#1771) * Per dtcenter/METplus-Internal#20, change log output to always include username and include user ID if it is available * Per dtcenter/METplus-Internal#20, fixed bug introduced from commit 458714c to develop where error is thrown if username cannot be obtained, which occurs in environment running GHA tests * Revert "Per dtcenter/METplus-Internal#20, fixed bug introduced from commit 458714c to develop where error is thrown if username cannot be obtained, which occurs in environment running GHA tests" This reverts commit fb2d093. * Revert "Per dtcenter/METplus-Internal#20, change log output to always include username and include user ID if it is available" This reverts commit 458714c. * per dtcenter/METplus-Internal#20, implemented working solution to user info logging * change file path based on change to MODE output from dtcenter/MET#2251 * fix Contributor's Guide GitHub Workflow page (#1774) * Feature dtcenter/METplus-Internal#32 add timestamp to final conf and file_lists (#1763) * Feature dtcenter/METplus-Internal#15 checksum for release (#1769) Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Feature dtcenter/METplus-Internal#32 change SCRUB_STAGING_DIR default and add documentation (#1784) * fix to allow wildcard characters in UserScript input templates, ci-run-all-diff * per #1787, allow NA instead of only integers for climo_mean/stdev hour_interval * per #1787, added test for setting NA for climo_mean hour_interval * Updating note format * update Python version to 3.8.6 * Revert "update Python version to 3.8.6" This reverts commit c1e6cbc. * added return value checking to error and exit a non-zero value if docker build or docker push fail * update instructions to find issues for a bugfix release (#1790) * Feature dtcenter/METplus-Internal#34 set the log time to UTC/GMT (#1793) * Feature #1330 MJO ENSO use case (#1794) Co-authored-by: cristianastan2 <cstan@gmu.edu> * Feature #1816 ensemble vx removal from EnsembleStat (#1820) Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Feature #1816 rename cases and files (#1823) Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Move files under internal_tests into internal/tests (#1818) * info for new use case * renamed picture of unrelated use case to properly display * Minor tweak to the release guide instructions for MET development releases. * Feature #1817 5.0.0-beta3 release (#1825) Co-authored-by: bikegeek <minnawin@ucar.edu> * Update VERSION * updated file name * updated MET file locations * explicitly set units for obs read via python embedding since PR dtcenter/MET#2288 no longer guesses units based on grib table units (which can be inaccurate of the actual data) * turn off precip use case group * Feature #1829 set unique ID in config (#1830) * fixed typo in use case setting that causes differences in the test output * Feature #1687 RuntimeFreq read only files needed for given run (#1841) * Feature 1847 release (#1850) * Per #1847, moved release notes to be its own chapter, reformatted component release notes, and added new section for upgrade instructions * Per #1847, added release-notes internal tag * Per #1847, fix error and reformat link * Per #1847, modified release instructions to add a section about upgrade instructions * Per #1847, modified release instructions to add a section about upgrade instructions * Per #1847, resolve doc warnings * Per #1847, updated instructions for clarity. * Per #1847, modified text and link. * Per #1847, modified wording and resolve error with note * Feature #1863 fix GitHub Actions warnings (#1864) * Feature #1874 prevent false diffs (#1875) * Feature 1842 StatAnalysis - multiple issues (#1869) * Bugfix #1884 develop PCPCombine {custom} in subtract method (#1887) * Feature 1852 use case physics tendency (#1881) * Issue #1852 initial work for the Planview plot * Issue #1852 planview plot for physics tendency * issue #1852 cleared away unused/unneccessary code * Issue #1852 update script command * Issue #1852 first draft, doesn't have correct content * Issue #1852 updated name of output plot to include short_range in name * Issue #1852 renamed to include fcstOnly label * Issue #1852 initial commit * Issue #1852 * Issue #1852 * Issue #1852 initial commit * issue #1852 vertical cross section * Issue 1852 clean up unused lines * Issue #1852 initial commit * Issue #1852 * Issue #1852 updates * Issue #1852 fixed documentation warnings, but some problems remain * fixing line length for chapter and section headers and one letter capitalization * cleaning up line spacing and trying to fix a critical error. * trying to fix critical error again * Issue #1852 more description for data and dependency on METplotpy with additional instructions * Issue #1852 update location of input data to single directory * Removing duplicate files with a misformatted name that are not needed * Per #1852, making changes to formatting to eliminate errors * Issue #1852 remove redundant yaml config file * Issue #1852 update PYTHONPATH information * Issue #1852 fixed conflicts * Issue #1852 update path to shapefile * Issue #1852 fixed copy and paste error * Issue #1852 add three use case entries: Planview, VerticalProfile, and VerticalCrossSection for the short range Physics tendency use case * Issue #1852 add latest short range tests to top, move down list when everything passes * Update use_case_groups.json move short_range use cases #10-12 to below the short range test for #9 * Issue #1852 clean up conf files by providing variables for the input netCDF files and for the planview plot, allow user to indicate pressure levels * Issue #1852 Indicate external Python packages * Issue #1852 added external dependency section * removed env vars that don't need to be set -- METPLOTPY_BASE is set by the automated test conf (.github/parm/test_settings.conf) and PYTHONPATH doesn't need to be set because METplotpy is installed in Python environment for use case tests * Update UserScript_fcstFV3_fcstOnly_PhysicsTendency_Planview.py Fixed one typo * Update UserScript_fcstFV3_fcstOnly_PhysicsTendency_VerticalCrossSection.py Fixed a typo * Update UserScript_fcstFV3_fcstOnly_PhysicsTendency_VerticalProfile.py Same typo, same fix * Issue #1852 remove extraneous entry for USER_SCRIPT_COMMAND, a hold-over from the original implementation which doesn't allow the user to easily specify the FV3 history file and grid spec netCDF file * Update UserScript_fcstFV3_fcstOnly_PhysicsTendency_VerticalProfile.conf Removed the incorrect USER_SCRIPT_COMMAND in previous commit. Reinstated the correct version and removed the incorrect command. * update html file from Planview to VerticalProfile Co-authored-by: Lisa Goodrich <lisag@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: Hank Fisher <fisherh@ucar.edu> * Feature #1893 StatAnalysis custom looping (#1894) * Feature dtcenter/METplus-Internal#24 test failure (#1895) * updated version for creating release (#1897) * update release number for development towards beta5 * Adding one sentence to about daily follow up on discussions. * initial changes for new use case * updated paths, documentation * updated automated testing files * Feature #344 rearrange utils (#1900) * first additions for new use case, corrected documentation for old use case * Move Docker scripts to be consistent with other METplus components (#1907) * added picture * Correct spelling mistake * handle if input to format_thresh is already a list * Revert "handle if input to format_thresh is already a list" This reverts commit d329275. * handle if input to format_thresh is already a list * per #1910, added time util function to add field info to time info dictionary and updated wrapper logic to use this function to add this info instead of passing field info (var_info) to CommandBuilder.find_data to get level info, ci-run-all-diff * change logic to preserve full level string for [fcst/obs]_level so SeriesAnalysis cases build the same file names, but parse out time info for setting generic level for string sub to preserve previous behavior * try setting all input values in output dictionary, ci-run-all-diff * removed commented code * add quotes around input files to plot_point_obs command to allow support for Python Embedding as input * put all arguments on single line * remove commented code * per #1910, added unit tests to ensure that level is set properly in the forecast input template * added script to create geovista conda environment via Docker to use in the automated use case tests * Feature 1561 use case ugrid python embedding (#1927) Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Feature 1453 use case iodav2 python embedding (#1930) Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * fix permissions for script that were somehow changed to be not executable * Bugfix #1939 develop - failure reading obs when zipped file also exists (#1941) * Feature #1819 alert users if updates to EnsembleStat use cases are needed (#1945) Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu> * fixed underline that did not match title * Feature #1898 tc new options (#1932) close undefined * fixed broken doc util logic from bad PR merge * Feature #1569 EnsembleStat -ens_mean argument (#1952) * Feature #1953 seeps config in GridStat and PointStat (#1954) Co-authored-by: johnhg <johnhg@ucar.edu> * Feature #1566 update Python version to 3.8.6 (#1958) * Feature #1956 5.0.0-beta4 release (#1963) * Update VERSION * added warning in release notes that location of METplus Dockerfile has changed * combined release notes for all betas for the v5.0.0 release * updated tags for each METplus component to match the upcoming release * Feature #1885 gh_projects (#1973) Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Switch from double to single quotes. * Update formatting of the GitHub project filters so that they can be copy/pasted directly from RTD into the GitHub project filter. * Feature #1953 PointStat output_flag.seeps and output_flag.seeps_mpr (#1976) * Feature #1711, #1783, #1814, and #1835 Documentation - Multiple files, PCPCombine constant init, Docker instructions, and MET links (#1967) Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu> * run diff logic on push for develop and main_v* branches, fix logic to properly run all use cases * fixed name of external * added Bugfix: to default title of new bugfix issue * added space after New Use Case: * changed references to METdatadb to METdataio that were missed * Update overview.rst Removed statsmodels from the table, this package is no longer a requirement. The necessary functionality was pulled out of the statsmodels repository and incorporated into the METcalcpy repository * Update overview.rst METdataio *must* only use pandas 1.2.3. METdataio also requires pyyaml. * Update overview.rst METdatio uses pytest to test aspects of the METreformat module * Update rotate_authorship.rst Explicitly add the step to commit and push changes to the file containing the author list. * Update overview.rst Added METdataio for lxml, numpy, pandas, and pymysql * Update finalize_release_on_github_official.rst added branch protection rules step and the interface to Github was modified, you need to click on the stacked '->' icon to switch default branches * CI: replace / with _ to prevent errors creating docker tags for tests * Update overview.rst included METdataio for python 3.8.6+ requirement * Update overview.rst psutil no longer needed in METplotpy and METcalcpy * Update overview.rst METcalcpy no longer requires imutils and allow versions 0.5.3 and above * Update overview.rst cleaned up formatting for imutils * change asterisk to double asterisk to match branches that include forward slash / * update version of certifi based on dependabot auto-generated PR #1982 * Feature 1819 format doc (#1981) Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Update use case keywords (#1984) * Feature #1980 Use the main_vX.Y of METplus components for main METplus tests (#1985) * Feature #1986 v5.0.0 release (#1987) Closes #1986 * updated version for development towards beta1 of 5.1.0 * allow rest of workflow to run even if job to update data volumes fails in case server is down * updated version for action to update input data volumes and added max number of DockerHub tag pages to search to 15 * updated release notes for official METplus release to untar the sample data for next version directory * Update release guide to create the input test data directory for official MET releases. * Follow the METplus naming conventions for updating the the DTC web server data. * install library needed for geovista package, remove editable flag so geovista code will be added directly to python instead of reading it from the source code location, ci-skip-all * Feature 685 log updates (#1992) * add script to create conda environment with MetPy 1.4 for SWPC use case * Bugfix develop Fix broken documentation links (#2004) * fixed bug to set environment variables in the RegridDataPlane environment instead of the PyEmbedIngest environment * Feature #2015 modulefiles (#2024) * Adding modulefile for WCOSS2 * Updated references of 4.1.1 to 5.0.0 * Feature #2005 updates to create v5.1 conda environments that use debian10 and Python 3.10.4 (#2043) * update versions to fix bugs for METplotpy/calcpy use cases * Bugfix #2026 develop StatAnalysis looping (#2028) * Feature #2022 update python version to 3.10.4 for repo files (#2047) * Feature #2022 Use Debian 10 / Python 3.10.4 in automated tests (#2050) * add use case group name to output path so that output and error logs will contain use case category to more easily see which case was run * remove -group0 from group names for output path * add manual workflow to update truth data * ci: set gh token on checkout to enable push, ci-skip-all * Set user name/email via git config to allow push * add token to checkout * Feature #2049 Multiple interp.type.method/width (#2051) * added missing argument to script if building envs locally * get main_vX.Y truth data if running on main_vX.Y branch * Updating README.md for label creation and adding bold to common_labels.txt * Updated color for bold label * Feature #2054 consensus.write_members in TCPairs (#2057) * Create LICENSE.md (#2061) * per #2006, fix priority of obs_window config variables so that wrapper-specific version is preferred over generic OBS_WINDOW_BEGIN/END (#2062) * Feature 2065 v5.1.0 beta1 (#2066) * updated version number * added release notes * Update docs/Users_Guide/release-notes.rst Co-authored-by: John Halley Gotway <johnhg@ucar.edu> --------- Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * updated version with -dev * adding sphinx design to 3 files so dropdown menus will work in the release notes. * fix version numbers for python requirements for building documentation * fixed tab vs spaces * Bugfix #2070 var list numeric order (#2072) * Adding files for jet and hera * added commented process list that was accidentally removed -- this is used if the pre-processing steps are needed * Bugfix #2087 develop docs_pdf (#2091) * Feature 2076 release dropdown menu (#2083) * test dropdowns * Update release-notes.rst Attempting to resolve WARNING * testing dropdowns * adding dropdown menus * testing dropdown remove from warning section * dropdown testing * dropdown menu tests * dropdown menus after the warnings section, the dropdown menu only has one space instead of the normal 2 spaces. If it has 2 spaces, it gets sucked into the warning section. * spaces with warning * no spaces for warning * Update release-notes.rst warning note has to be indented 1 space. Originally it was no spaces but then all of the dropdown menus end up in the warning message. If it's 2 spaces, as is normal, then the warning is indented, which is unnecessary. 1 space is slightly indented and keeps the dropdown menus separate. --------- Co-authored-by: jprestop <jpresto@ucar.edu> * Bugfix #2096/#2098 develop - fix skip if output exists and do not error if no commands were run (#2099) * Feature 1516 use case mvmode (#2094) Co-authored-by: Tracy Hertneky <hertneky@seneca.rap.ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Fix for Dockerfile smell DL4000 (#2112) Co-authored-by: Giovanni Rosa <giovanni.rosa@unimol.it> * Changed "PROJECT" to "CYCLE" ASSIGNMENT * Feature 2115 update use cases (#2133) * Bugfix #2082 develop regrid.convert/censor_thresh/censor_val (#2140) fix #2082 main_v5.0 regrid.convert/censor_thresh/censor_val (#2101) * Bugfix #2137 develop PointStat -obs_valid_beg/end (#2141) * Feature #2143 5.1.0-beta2 release (#2144) * update release guide steps with new info based on changes to GitHub web interface * update version for development towards rc1 release * Feature #1977 ARGO use case (#2148) Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> * Feature develop cycle change (#2150) * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT * Added paths to ignore --------- Co-authored-by: jprestop <jpresto@ucar.edu> * Documentation: Update Truth Data instructions (#2154) * upgrade python to 3.10 for documentation builds to fix failured introduced by urllib3 (see urllib3/urllib3#2168) * update workflow to update input test data to use branch from pull down or enter branch by hand if branch does not exist in dtcenter/METplus repo, e.g. if updating data for a PR coming from a fork * Bugfix #2161 develop PCPCombine additional field arguments in -subtract mode (#2162) * changed order of workflow event triggering info to more easily see the repository and commit sha that triggered the workflow * fix docker compose install and call -- needed due to new Alpine Linux release 3.18.0 that does not include docker-compose in the apk repository * Bugfix #2168 develop - StatAnalysis time shift (#2169) * Feature 1978 update pyreq doc (#2177) * Updating for 5.1.0 * Adding greater than or equal to signs * Feature 2106 release support (#2182) * Added a paragraph for Release Support Policy * Added a sentence about contacting the team through the METplus GitHub Discussions Forum. * Added Release Support Policy info * Per #2159, modify instructions to reflect that we only want a coordinated release for the official releases and updates to the coordinated release section for the bugfix releases. (#2183) * Feature 2147 workflow doc (#2185) * Add new images for github workflow * Added PR section * Modified the Find the GitHub Issue to be Find or Create a GitHub issue * Trying out image keyword compared with figure keyword * Trying out various widths * Added new figures * Reverting to figures from images after modifying figures * Adding the old images which are better quality * Trying out new indention * Working on formatting again * Reducing image widths * Update docs/Contributors_Guide/github_workflow.rst Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Update docs/Contributors_Guide/github_workflow.rst Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Update docs/Contributors_Guide/github_workflow.rst Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Update github_workflow.rst --------- Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * added scripts to create new conda environment for PANDA-C use cases * Bugfix #2189 develop - spaces in complex thresholds (#2191) * added release notes for completed issues for rc1 * Feature 2011 tci from cesm fluxnet2015 netcdf (#2192) Co-authored-by: Mrinal Biswas <biswas@seneca.rap.ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Bugfix #2179 develop TCPairs fix -diag argument (#2187) * sort list of files to make command more readable and make logic more easily testable * fix unit test to expect alphabetical order of files * Feature #2197 MODE new multi-variate options (#2203) * added to release notes * added release notes for other items completed for rc1 release * Feature #1626 TCDiag Wrapper (#2201) * Feature #1610 first round of SonarQube fixes (#2200) * Feature #2195 create v5.1.0-rc1 release (#2204) * Update version for development towards official release * updated script to use metplotpy as base and install pygrib because conda was failing trying to install matplotlib in Docker for some strange reason * Feature 2188 use case panda c (#2202) * added first use case, need to finish docs and add to list * added documentation files, 3 new cases * added 5th use case, docs * final use case, corrected paths for output * Update GridStat_fcstGFS_obsERA5_lowAndTotalCloudFrac.py * removed chars, added space to last section --------- Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com> Co-authored-by: bikegeek <minnawin@ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: Hank Fisher <fisherh@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: cristianastan2 <cstan@gmu.edu> Co-authored-by: j-opatz <jopatz@ucar.edu> Co-authored-by: Lisa Goodrich <lisag@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Co-authored-by: Will Mayfield <59745143+willmayfield@users.noreply.github.com> Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com> Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com> Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com> Co-authored-by: Tracy Hertneky <hertneky@seneca.rap.ucar.edu> Co-authored-by: Giovanni Rosa <g.rosa1@studenti.unimol.it> Co-authored-by: Giovanni Rosa <giovanni.rosa@unimol.it> Co-authored-by: mrinalbiswas <biswas@ucar.edu> Co-authored-by: Mrinal Biswas <biswas@seneca.rap.ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Confirmed that test listed in issue now reports accum time of 0 rather than NA:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review code changes.
Check to see if any GHA tests fail.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
No doc updates needed.
Do these changes include sufficient testing updates? [No]
No testing updates needed.
Will this PR result in changes to the test suite? [???]
If yes, describe the new output and/or changes to the existing output:
I don't know. Will let GHA tests run for this PR and check to see if any outputs have changed.
Please complete this pull request review by [Tues 9/5/22].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes