Remaining reference to ARIMA in utils.py compute_std_err_from_median_variance_inflation_factor()

[bikegeek]

Describe the Problem

In METcalcpy/metcalcpy/util/utils.py, the compute_std_err_from_median_variance_inflation_factor function is referencing the ARIMA function from statsmodels (line 958):

    arima = ARIMA(data_excursions, order=(1, 0, 0))
    ar_1 = arima.fit().arparams[0]

Expected Behavior

If a user is invoking this function, there will be a module not found error (or something to that effect) due to no ARIMA

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Organization level Project for support of the current coordinated release
• Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Bugfix Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of main_<Version>.
  Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
• Fix the bug and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into main_<Version>.
  Pull request: bugfix <Issue Number> main_<Version> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Development issues
  Select: Organization level software support Project for the current coordinated release
  Select: Milestone as the next bugfix version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Complete the steps above to fix the bug on the develop branch.
  Branch name: bugfix_<Issue Number>_develop_<Description>
  Pull request: bugfix <Issue Number> develop <Description>
  Select: Reviewer(s) and Development issues
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Close this issue.

[bikegeek]

following what was done in util.comput_std_err_from_mean():
replace this:

arima = ARIMA(data_excursions, order=(1, 0, 0))
ar_1 = arima.fit().arparams[0]

with this:
ar_1 = autocor_coef(data)

[bikegeek]

also removed code that is no longer used (needed when invoking ARIMA):

Use excursions from the median to compute the first order auto-correlation coefficient.

    data_excursions = list()
    median = st.median(data)
    for val in data:
        if val >= median:
            data_excursions.append(1)
        else:
            data_excursions.append(0)

    arima = ARIMA(data_excursions, order=(1, 0, 0))
    ar_1 = arima.fit().arparams[0]

replaced by:
ar_1 = autocor_coef(data)