Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 292 release dropdown menu #294

Merged
merged 11 commits into from
Mar 28, 2023
Merged

Conversation

lisagoodrich
Copy link
Contributor

@lisagoodrich lisagoodrich commented Mar 27, 2023

Pull Request Testing

  • Describe testing already performed for these changes:

    I've added dropdown menus to the release note section. The below files have been changed so the dropdown menus will work:
    config.py
    docs/requirements.txt file.
    METcalcpy/.github/workflows/documentation.yml

I have tested all of the dropdown menus.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please open a couple of the dropdown menus. Let me know if there are any problems or inconsistencies. All should be running smoothly. Here is the link:
    https://metcalcpy.readthedocs.io/en/feature_292_release_dropdown_menu/Users_Guide/release-notes.html

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [n/a]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [4/4/23].
    Date is negotiable.

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@lisagoodrich lisagoodrich added this to the METcalcpy 2.1.0 milestone Mar 27, 2023
@lisagoodrich lisagoodrich linked an issue Mar 27, 2023 that may be closed by this pull request
19 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lisagoodrich for making these changes. I have reviewed the content, both within the PR and via RTD, and everything looks good. Unfortunately, some "Python vulnerability checks" are failing. I do not know why this is, but I believe it does not have to do with your changes. I am going to reassign this PR to @bikegeek, because she will have a better idea of what the error is about and how to fix it. I defer approval to her, pending the passing of the tests.

@jprestop jprestop requested review from bikegeek and removed request for bikegeek March 27, 2023 19:09
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bikegeek was able to resolve the testing failures (thank you!). I approve this pull request.

@jprestop jprestop merged commit c0d67cf into develop Mar 28, 2023
@lisagoodrich lisagoodrich deleted the feature_292_release_dropdown_menu branch March 28, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhance the Release Notes by adding dropdown menus
2 participants