-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 292 release dropdown menu #294
Conversation
rolling Python version 3.10 back to 3.8 so that dropdown menus will work
I had to update .github/workflows/documentation.yml from Python 3.10 back to 3.8 so that the dropdown menus will work.
I removed what I just added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lisagoodrich for making these changes. I have reviewed the content, both within the PR and via RTD, and everything looks good. Unfortunately, some "Python vulnerability checks" are failing. I do not know why this is, but I believe it does not have to do with your changes. I am going to reassign this PR to @bikegeek, because she will have a better idea of what the error is about and how to fix it. I defer approval to her, pending the passing of the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bikegeek was able to resolve the testing failures (thank you!). I approve this pull request.
Pull Request Testing
I've added dropdown menus to the release note section. The below files have been changed so the dropdown menus will work:
config.py
docs/requirements.txt file.
METcalcpy/.github/workflows/documentation.yml
I have tested all of the dropdown menus.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please open a couple of the dropdown menus. Let me know if there are any problems or inconsistencies. All should be running smoothly. Here is the link:
https://metcalcpy.readthedocs.io/en/feature_292_release_dropdown_menu/Users_Guide/release-notes.html
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [n/a]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [4/4/23].
Date is negotiable.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes