Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 302 derived curve #305

Merged
merged 2 commits into from
May 12, 2023
Merged

Issue 302 derived curve #305

merged 2 commits into from
May 12, 2023

Conversation

TatianaBurek
Copy link
Collaborator

  • Describe testing already performed for these changes:

  • created and run testing script test_agg_ratio.py

  • tested with GUI on dakota

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • run testing script test_agg_ratio.py

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@TatianaBurek TatianaBurek added this to the METcalcpy 2.1.0 milestone May 12, 2023
@TatianaBurek TatianaBurek linked an issue May 12, 2023 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass

@bikegeek bikegeek merged commit a4abc9a into develop May 12, 2023
4 checks passed
@bikegeek bikegeek deleted the issue_302_derived_curve branch May 12, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ratio Derived curve does not get generated for series with different statistics
2 participants