Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 306 pstd roc auc #307

Merged
merged 5 commits into from
May 23, 2023
Merged

Issue 306 pstd roc auc #307

merged 5 commits into from
May 23, 2023

Conversation

TatianaBurek
Copy link
Collaborator

  • Describe testing already performed for these changes:

  • created test_roc_auc test in test_agg_stats_and_boot.py

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • run test_roc_auc test in test_agg_stats_and_boot.py

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@TatianaBurek TatianaBurek added this to the METcalcpy 2.1.0 milestone May 15, 2023
@TatianaBurek TatianaBurek linked an issue May 15, 2023 that may be closed by this pull request
22 tasks
@bikegeek
Copy link
Collaborator

@TatianaBurek , there isn't a test_roc_auc in the METcalcpy/test directory.

@TatianaBurek
Copy link
Collaborator Author

test_roc_auc is a test inside of test_agg_stats_and_boot.py

Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests successfully passed on 'seneca'

@bikegeek bikegeek merged commit 5327bdb into develop May 23, 2023
4 checks passed
@bikegeek bikegeek deleted the issue_306_PSTD_ROC_AUC branch May 23, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect calculation of PSTD_ROC_AUC statistic
2 participants