Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Spacetime files #310

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Conversation

CPKalb
Copy link
Contributor

@CPKalb CPKalb commented Jun 6, 2023

Pull Request Testing

  • Describe testing already performed for these changes:

    Tested the scripts offline.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Check the code to make sure it all makes sense. We will be able to do a more thorough test when the METplus use case is merged (which has to happen after this pull request is completed)

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    Will include changes in the METplus output but I don't think here

  • Please complete this pull request review by [Fill in date].

    as soon as possible

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@CPKalb CPKalb requested a review from hankenstein2 June 6, 2023 19:01
@CPKalb CPKalb added type: enhancement Improve something that it is currently doing requestor: NOAA/other NOAA Laboratory, not otherwise specified labels Jun 6, 2023
@CPKalb CPKalb added this to the Consider for Next Release milestone Jun 6, 2023
@CPKalb CPKalb linked an issue Jun 6, 2023 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@hankenstein2 hankenstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hankenstein2 hankenstein2 merged commit f1a612b into develop Jun 7, 2023
6 checks passed
@hankenstein2 hankenstein2 deleted the feature_303_cross_spectra branch June 7, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requestor: NOAA/other NOAA Laboratory, not otherwise specified type: enhancement Improve something that it is currently doing
Projects
No open projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

Merge in changes to the Cross Spectra
2 participants