Feature 325 aggregation support #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update required Python version to 3.10+
…feature_325_aggregation_support
creating file from:https://github.com/dtcenter/METcalcpy/blob/feature_325_aggregation_support/metcalcpy/pre_processing/aggregation/README.md Copied Vertical Interpolation as a template
… another script
…(included the path to the agg_stat.py module)
…py agg_stat input
not used for testing. Using the ECNT data instead.
… and aggregation statistics calculated
…dtcenter/METcalcpy into feature_325_aggregation_support
…to fail. Remove pandas chaining such as: df['column_name'][index] = var_name with: df.loc[index, 'column_name'] = var_name
…to fail. Remove pandas chaining such as: df['column_name'][index] = var_name with: df.loc[index, 'column_name'] = var_name
… of expected input format for agg_stat.
added test_reformatted_for_agg.py
…dtcenter/METcalcpy into feature_325_aggregation_support
hankenstein2
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Vanderlei has generated plots from the aggregated data and visually verified that they are correct/expected.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Follow instructions in the ReadtheDocs to ensure instructions are correct
Run all METcalcpy tests by running run_all_nco.sh under METcalcpy/test
Can also run the test_reformatted_for_agg.py under METcalcpy/test
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes