Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 345 main gha node20 #348

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Conversation

lisagoodrich
Copy link
Contributor

@lisagoodrich lisagoodrich commented Jan 26, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    I ran the commands John HG listed in the issue

Command to make sure old stuff isn’t there:
Old:
grep checkout@v3 *
grep artifact@v3 *
grep setup-python@v4%g *
grep github-script@v6%actions *

New:
grep checkout@v4 *
grep artifact@v4 *
grep setup-python@v5%g *
grep github-script@v7%actions *

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    I am unable to complete manual testing with the workflow dispatch option for this component. Please test to make sure this is working as needed.
    Please check "Milestone". I'm not sure I picked the right one.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [INo]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [1/31/24].
    >

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@lisagoodrich lisagoodrich added this to the METcalcpy-2.0.3 (bugfix) milestone Jan 26, 2024
@lisagoodrich lisagoodrich linked an issue Jan 26, 2024 that may be closed by this pull request
21 tasks
@lisagoodrich
Copy link
Contributor Author

Below is the message from the "documentation_warnings.log"

/home/runner/work/METcalcpy/METcalcpy/docs/sg_execution_times.rst:35: WARNING: undefined label: 'sphx_glr_auto_examples_cross_spectra.py'

Should this be removed? I didn't get an error in the "develop" branch.

Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @lisagoodrich. It looks good to me. I'll approve and squash and merge and check to ensure the warning goes away.

@jprestop jprestop merged commit 5a4bfd6 into main_v2.1 Feb 2, 2024
6 checks passed
@jprestop jprestop deleted the feature_345_main_gha_node20 branch February 2, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Update GitHub actions workflows to switch from node 16 to node 20
2 participants