Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature_342_add_write_mpr_file #359

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

CPKalb
Copy link
Contributor

@CPKalb CPKalb commented Feb 8, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    Tested the use case to be sure it works

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Check out the following branches of METplus, METcalcpy, METplotpy, and METdataio
    feature_1344_stratosphere_bias of METplus
    feature_342_write_mpr_file METcalcpy
    develop branch of METplotpy
    develop branch of METdataio

Run 1 use cases, s2s/UserScript_fcstGFS_obsERA_StratospherePolar.conf. Verify that the StratospherePolar use case produces output mpr files located in s2s/UserScript_fcstGFS_obsERA_StratospherePolar/mpr

The documentation is located in docs/Users_Guide/write_mpr.rst

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes

  • Do these changes include sufficient testing updates? [Yes or No]
    Tests will be added under issue 358

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    No

  • Please complete this pull request review by [Fill in date].

    02/13/2024

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@CPKalb CPKalb requested a review from bikegeek February 8, 2024 22:14
@CPKalb CPKalb linked an issue Feb 8, 2024 that may be closed by this pull request
22 tasks
@CPKalb CPKalb added this to the Consider for Next Release milestone Feb 8, 2024
@CPKalb CPKalb changed the title Adding a file Feature_342_add_write_mpr_file Feb 8, 2024
@bikegeek
Copy link
Collaborator

bikegeek commented Feb 8, 2024

checked out the develop version of METdataio because bugfix_247_readnc_no_lon was merged into develop and the branch no longer exists.

@CPKalb
Copy link
Contributor Author

CPKalb commented Feb 9, 2024

Ah, that's right. I'll update the comment to reflect this

@bikegeek
Copy link
Collaborator

@CPKalb after finding ERRORS in my log file/unsuccessful end-to-end run, I re-ran the use case with a Process list with only one of the steps at a time. The plotting steps are the issue:

Running wrapper: UserScript(plots_t)
02/10 17:42:44.345Z metplus.e49d1a9c (command_builder.py:563) WARNING: Could not find any INPUT files

I'm running on 'seneca'. I used the ERA and GFS data from your scratch directory on 'derecho'

@CPKalb
Copy link
Contributor Author

CPKalb commented Feb 12, 2024

Let me take a look at this. I did most of my testing on cheyenne, so perhaps something is not working right on a new machine.

Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully ran the suggested use case, generated two ME plots and two RMSE plots.

@bikegeek bikegeek merged commit 563bcb4 into develop Feb 13, 2024
7 checks passed
@bikegeek bikegeek deleted the feature_342_write_mpr_file branch February 13, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the MPR file write script from the Blocking/WR area to the util area
2 participants