Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 362 ctc sorting #363

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Bugfix 362 ctc sorting #363

merged 3 commits into from
Mar 4, 2024

Conversation

bikegeek
Copy link
Collaborator

  • Describe testing already performed for these changes:

    Cloned repo on 'seneca' and using conda environment: /d1/personal/mwin/miniconda3/envs/mp_analysis_env
    ran all the unit tests for METcalcpy by running $METCALCPY_BASE/metcalcpy/test/run_all_nco.sh

(added nan and compound thresholds to the input data for the test_ctc_statistics.py)

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

perform the same as above. On 'seneca', the conda environment has permissions set to allow others in the same group to activate:

/d1/personal/mwin/miniconda3/envs/mp_analysis_env

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek added this to the METcalcpy-3.0.0 milestone Feb 27, 2024
@bikegeek bikegeek linked an issue Feb 27, 2024 that may be closed by this pull request
23 tasks
Copy link
Collaborator

@hankenstein2 hankenstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hankenstein2 hankenstein2 merged commit 1f9ee8c into develop Mar 4, 2024
6 checks passed
@hankenstein2 hankenstein2 deleted the bugfix_362_ctc_sorting branch March 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

Successfully merging this pull request may close these issues.

CTC sort_by_thresh does not support nan and multiple comparison operators
2 participants