Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #366 develop sonarqube_gha #367

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

JohnHalleyGotway
Copy link
Contributor

@JohnHalleyGotway JohnHalleyGotway commented Apr 4, 2024

These are the same set of changes made to the METdataio repository by dtcenter/METdataio#290.
Note that I will also sumbit a PR to merge these changes into the main_v2.1.

Note that the METcalcpy repo was configured to define the SONAR_HOST_URL which was overriding the organization-wide setting. That's what the sonarqube.yml workflow kept failing. Once I removed that repo-specific secret, the workflow began working nicely, as expected.

@JohnHalleyGotway JohnHalleyGotway added this to the METcalcpy-3.0.0 milestone Apr 4, 2024
@JohnHalleyGotway JohnHalleyGotway marked this pull request as draft April 4, 2024 19:16
@JohnHalleyGotway JohnHalleyGotway marked this pull request as ready for review April 5, 2024 00:56
@bikegeek bikegeek merged commit c531506 into develop Apr 8, 2024
7 checks passed
@bikegeek bikegeek deleted the feature_366_develop_sonarqube_gha branch April 8, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add GitHub action to run SonarQube for METcalcpy pull requests and feature branches
2 participants