Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 361 aggstats for linetypes #372

Merged
merged 34 commits into from
Apr 15, 2024

Conversation

bikegeek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    on 'seneca':

  • work in 'bash' shell

  • checkout feature_361_aggstats_for_linetypes

  • use conda environment: /d1/personal/mwin/miniconda3/envs/mp_analysis_env

  • run the pytests:

    • cd $METCALCPY_BASE/test/
    • sh run_all_nco.sh (includes latest test for linetype additions)
    • individually run the tests that verify the output from MET stat_analysis to METcalcpy agg_stat:
    • pytest test_agg_stat.py
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Perform similar steps as above (easier to do this on 'seneca', using the existing conda environment)

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [before April 15].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek added component: plot point data priority: high High Priority requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project METcalcpy: General Statistics labels Apr 10, 2024
@bikegeek bikegeek added this to the METcalcpy-3.0.0 milestone Apr 10, 2024
hankenstein2
hankenstein2 previously approved these changes Apr 15, 2024
Copy link
Collaborator

@hankenstein2 hankenstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the tests, looks good

@hankenstein2 hankenstein2 merged commit d978cf2 into develop Apr 15, 2024
7 of 8 checks passed
@hankenstein2 hankenstein2 deleted the feature_361_aggstats_for_linetypes branch April 15, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plot point data METcalcpy: General Statistics priority: high High Priority requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants