Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 379 requirements #380

Merged
merged 3 commits into from
May 13, 2024
Merged

Feature 379 requirements #380

merged 3 commits into from
May 13, 2024

Conversation

lisagoodrich
Copy link
Contributor

@lisagoodrich lisagoodrich commented May 9, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    I've reviewed the Contributor's Guide Requirements web page with the new 'literal include' linking to the requirements.txt file

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
    .
    Please confirm the web page is what is expected.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 5/13/24.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@lisagoodrich lisagoodrich requested a review from jprestop May 9, 2024 21:55
@lisagoodrich lisagoodrich linked an issue May 9, 2024 that may be closed by this pull request
22 tasks
@jprestop jprestop added this to the METcalcpy-3.0.0 milestone May 13, 2024
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes in the documentation and verified that all tests passed. I approve this request. Thank you for your work on this task, @lisagoodrich.

@jprestop jprestop merged commit 39b5e3b into develop May 13, 2024
6 checks passed
@jprestop jprestop deleted the feature_379_requirements branch May 13, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Modify Requirements section of the Contributors's Guide
2 participants