METplus-Internal_39 SonarQube scanning

[hsoh-u]

Pull Request Testing

• Describe testing already performed for these changes:
  

It's configured to scan the code nightly at seneca under met_test account by cron.

• Clone the develop branch from the github repository
• Scan python scripts
• Send the scanning result to mandan where SonarQube server is running

The scanning result is viewable by web browser at http://mandam:9090. The user name and password exist at sonar-project.properties

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

  • login to seneca
  • login as met_test (runas met_test) or modify internal_tests/scanning/sonarqube/development.seneca after cloning
  • clone from github
  • run following command

   ./internal_tests/scanning/sonarqube/run_nightly.sh develop

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[bikegeek]

The Github actions test for compare two databases has been consistently failing prior to this work. I've asked Venita about this but I'm going to approve this PR because the sonarqube scanning is working.

[bikegeek]

Successfully ran the scan and viewed the dashboard. METdataio sonarqube passes. The Github Actions test: compare two databases has been failing on earlier pushes for other branches. I'm approving this because it appears that these changes are not responsible for the database tests failing.