Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update the METplus Components Python Requirements #2016

Closed
9 of 22 tasks
jprestop opened this issue Jan 20, 2023 · 9 comments · Fixed by #2044 or #2177
Closed
9 of 22 tasks

Documentation: Update the METplus Components Python Requirements #2016

jprestop opened this issue Jan 20, 2023 · 9 comments · Fixed by #2044 or #2177
Assignees
Labels
component: documentation Documentation issue priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work
Milestone

Comments

@jprestop
Copy link
Collaborator

jprestop commented Jan 20, 2023

Describe the Task

Update the METplus Components Python Requirements Documentation for the METplus Analysis tools for recent changes based on testing for official installation on WCOSS2 the upcoming bugfix release and in the develop branch to ensure that they are current. This documentation be used by NCO.

Time Estimate

<1 day

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

METplus Analysis Tools Bugfix Release (01/25/2023), although it won't be published until the METplus Bugfix Release.

Funding Source

Split between 2792542 and 2773542

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions (Need to select two Milestones, but can only select one so I listed the Bugfix release)

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@jprestop jprestop added component: documentation Documentation issue priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work requestor: METplus Team METplus Development Team labels Jan 20, 2023
@jprestop jprestop added this to the METplus-5.0.1 Bugfix milestone Jan 20, 2023
@georgemccabe
Copy link
Collaborator

This may be a duplicate of #1978

@jprestop
Copy link
Collaborator Author

Thanks @georgemccabe. It's not a duplicate. There were some changes made to versions of packages for the METplus Analysis tools but this page has not yet been updated. I neglected to put "for the METplus Analysis tools" in the description so I just added it.

@jprestop
Copy link
Collaborator Author

jprestop commented Feb 6, 2023

Hi @bikegeek. I see that this was moved from "Backlog" to "Done" for METplus Version 5.0 Support, but it doesn't look like it has been fully reviewed and updated as I still see the following:

pandas | >=1.0.5, <=1.2.3 (METdataio)

I didn't check any others, that one just jumped out at me. @georgemccabe was interested in knowing when this would be complete as he is hoping to cut the METplus bugfix release sometime soon, so I wanted to follow up.

@bikegeek
Copy link
Contributor

bikegeek commented Feb 7, 2023 via email

@bikegeek bikegeek linked a pull request Feb 9, 2023 that will close this issue
14 tasks
bikegeek added a commit that referenced this issue Feb 14, 2023
bikegeek added a commit that referenced this issue Feb 16, 2023
#2044)

* Issue #2016 update the Python versions used by the METplus analysis tools

* Issue #2016 update netcdf version to be consistent with NCO version

* Issue #2016 Remove yaml
@georgemccabe
Copy link
Collaborator

@bikegeek , @jprestop, It looks like this issue was moved to "Done" for the METplus-5.1.0 Development project, but I don't see a PR for these changes into the develop branch. It looks like the changes were not applied to develop. Re-opening this issue.

@georgemccabe georgemccabe reopened this Apr 10, 2023
@georgemccabe georgemccabe changed the title Update the METplus Components Python Requirements Documentation Documentation: Update the METplus Components Python Requirements Apr 10, 2023
@jprestop
Copy link
Collaborator Author

@bikegeek , @jprestop, It looks like this issue was moved to "Done" for the METplus-5.1.0 Development project, but I don't see a PR for these changes into the develop branch. It looks like the changes were not applied to develop. Re-opening this issue.

Thanks @georgemccabe. I updated the milestone to be METplus-5.1.0 from METplus-5.0.1.

I see that @bikegeek mentioned earlier:

I will update it, I was waiting to get the versions from upgrading to Python 3.10 solidified.

@bikegeek Do you feel that they are solidified now? Will you be able to do this before the beta2 release on Wednesday or should we reassign to the rc1 release instead?

@georgemccabe
Copy link
Collaborator

@bikegeek, since I haven't heard back I am going to move this to rc1. Let me know if this has already been completed and I'll move it back.

@bikegeek
Copy link
Contributor

bikegeek commented Apr 27, 2023 via email

@jprestop jprestop linked a pull request May 17, 2023 that will close this issue
14 tasks
@jprestop
Copy link
Collaborator Author

This issue can be closed with the work done in #1978 and with the PR #1978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue priority: high High Priority requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work
Projects
3 participants