Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable MET_BIN_DIR to replace {MET_INSTALL_DIR}/bin in the code #502

Closed
17 of 19 tasks
jprestop opened this issue Jun 8, 2020 · 0 comments
Closed
17 of 19 tasks
Assignees
Labels
component: release engineering Release engineering issue priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center type: bug Fix something that is not working type: task An actionable item of work

Comments

@jprestop
Copy link
Collaborator

jprestop commented Jun 8, 2020

Describe the Problem

METplus wrappers scripts currently reference {MET_INSTALL_DIR}/bin, expecting the MET executables to be located in a "bin" directory. However, NCO has asked for the executables to be in an "exec" directory, so we need to make this modifiable for the user.

Expected Behavior

Replace {MET_INSTALL_DIR}/bin with MET_BIN_DIR throughout the code so that the user can change if necessary and the scripts will find the MET executables.

Environment

Describe your runtime environment:
*1. Machine: WCOSS mars/venus and surge/luna
*2. OS: Linux

To Reproduce

Describe the steps to reproduce the behavior:
*1. Install the MET software using the --bindir option to install in a location other than "bin"
*2. Install the METplus software
*3. Run a use case
*4. Find that METplus cannot find the MET executables

Relevant Deadlines

METplus-3.1 release

Funding Source

?

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required (Julie Prestopnik)
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of master_<Version>.
    Branch name: bugfix_502_create_configurable_bin_dir
  • Fix the bug and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into master_<Version>.
    Pull request: bugfix <Issue Number> master_<Version> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
  • Close this issue.
@jprestop jprestop added type: bug Fix something that is not working priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work component: release engineering Release engineering issue labels Jun 8, 2020
@jprestop jprestop added this to the METplus-3.1 Release milestone Jun 8, 2020
@jprestop jprestop self-assigned this Jun 8, 2020
@jprestop jprestop added this to Pull Request Review in METplus-3.1-beta2 (6/20/2020) Jun 10, 2020
METplus-3.1-beta2 (6/20/2020) automation moved this from Pull Request Review to Done Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: release engineering Release engineering issue priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center type: bug Fix something that is not working type: task An actionable item of work
Projects
No open projects
Development

No branches or pull requests

1 participant