Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master_metplus.py to run_metplus.py #794

Closed
7 of 21 tasks
georgemccabe opened this issue Feb 8, 2021 · 0 comments · Fixed by #805
Closed
7 of 21 tasks

Rename master_metplus.py to run_metplus.py #794

georgemccabe opened this issue Feb 8, 2021 · 0 comments · Fixed by #805
Assignees
Labels
component: code cleanup Code cleanup and maintenance issue priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

To avoid using problematic terminology, we should rename master_metplus.py.

Describe the Enhancement

Rename the script to run_metplus.py. Create a symbolic link so that master_metplus.py will still work for users temporarily. Add release notes to encourage users to switch to using run_metplus.py instead.

Time Estimate

~ 1 hour

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

4.0.0 - we would like to incorporate major changes into a major release.

Funding Source

None

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing priority: high High Priority component: code cleanup Code cleanup and maintenance issue requestor: METplus Team METplus Development Team labels Feb 8, 2021
@georgemccabe georgemccabe added this to the METplus-4.0 milestone Feb 8, 2021
@georgemccabe georgemccabe self-assigned this Feb 8, 2021
@georgemccabe georgemccabe linked a pull request Feb 16, 2021 that will close this issue
10 tasks
@TaraJensen TaraJensen added the reporting: DTC NCAR Base NCAR Base DTC Project label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: code cleanup Code cleanup and maintenance issue priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants