Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2096/#2098 main_v5.0 - fix skip if output exists and do not error if no commands were run #2100

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

georgemccabe
Copy link
Collaborator

Same changes as PR #2099

Pull Request Testing

  • Describe testing already performed for these changes:
  • Added unit test to confirm bug, then updated logic to get test to pass
  • Modified basic use case GridStat.conf and renamed output files to change forecast lead to confirm behavior and confirmed that the fix resolved the issue
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  • Ensure all automated tests pass
  • Check that use case that incorrectly skipped runs now behaves as expected
  • Check that no errors are reported if no commands are run
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    New unit tests were added but they should all pass

  • Please complete this pull request review by 3/27/2023.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…r tests and add tests to demonstrate bug that incorrectly skips grid_stat runs when a given valid time has already been processed
…t files for apps that create multiple output files
@malloryprow
Copy link
Contributor

This worked great!

03/24 13:34:30.504 metplus (command_builder.py:1008) DEBUG: Skip writing output /scratch1/NCEPDEV/global/Mallory.Row/VRFY/test_METplus/pr_2100/output/grid_stat/grid_stat_2400000L_20200621_120000V*

@georgemccabe georgemccabe merged commit 19bc960 into main_v5.0 Apr 4, 2023
@georgemccabe georgemccabe deleted the bugfix_2096_main_v5.0_skip_grid_stat branch April 4, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants