Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #2082 main_v5.0 regrid.convert/censor_thresh/censor_val #2101

Merged
merged 12 commits into from Apr 4, 2023
Merged

Bugfix #2082 main_v5.0 regrid.convert/censor_thresh/censor_val #2101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
05d78b0
add support for adding (x) after a MET variable name, e.g. convert ->…
georgemccabe Mar 22, 2023
a8e8062
update TCPairs wrapper to use new add_x functionality to set diag_con…
georgemccabe Mar 22, 2023
a1ea9b1
per #2082, add support for setting convert, censor_thresh, and censor…
georgemccabe Mar 22, 2023
7fff4a8
fixed bug where unset _THRESH variable causes unlogged failure in wra…
georgemccabe Mar 23, 2023
afb8b7e
fixed bug to allow string for conv_radius e.g. grid_res/20 -- previou…
georgemccabe Mar 23, 2023
a9e0a87
per #2082, added documentation and unit tests for new config variable…
georgemccabe Mar 23, 2023
ee3df42
turn on use case group that is producing differences and add new sett…
georgemccabe Mar 23, 2023
0658c1e
add logic to use main_vX.Y truth data for branches that include main_…
georgemccabe Mar 23, 2023
e50f0ab
clean up tests
georgemccabe Mar 23, 2023
c9b5f79
per #2082, call handle_regrid function instead of handling regrid dic…
georgemccabe Mar 23, 2023
92f42ab
minor change to trigger run, ci-run-diff, ci-skip-unit-tests
georgemccabe Mar 23, 2023
0e6e96b
turn off use case group
georgemccabe Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/jobs/setup_and_run_diff.py
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@
import sys
import subprocess
import shlex
import re

from docker_utils import VERSION_EXT, get_branch_name

Expand Down Expand Up @@ -32,8 +33,9 @@
output_data_branch = os.environ.get('GITHUB_BASE_REF')
else:
branch_name = get_branch_name()
if branch_name.startswith('main_v'):
output_data_branch = branch_name
match = re.match(r'.*(main_v\d+\.\d+).*', branch_name)
if match:
output_data_branch = match.group(1)
else:
output_data_branch = 'develop'

Expand Down
165 changes: 165 additions & 0 deletions docs/Users_Guide/glossary.rst
View file
Open in desktop
Expand Up @@ -10243,3 +10243,168 @@ METplus Configuration Glossary
Specify the value for 'seeps_p1_thresh' in the MET configuration file for PointStat.

| *Used by:* PointStat

ENSEMBLE_STAT_REGRID_CONVERT
Specify the value for 'regrid.convert' in the MET configuration file for EnsembleStat.

| *Used by:* EnsembleStat

ENSEMBLE_STAT_REGRID_CENSOR_THRESH
Specify the value for 'regrid.censor_thresh' in the MET configuration file for EnsembleStat.

| *Used by:* EnsembleStat

ENSEMBLE_STAT_REGRID_CENSOR_VAL
Specify the value for 'regrid.censor_val' in the MET configuration file for EnsembleStat.

| *Used by:* EnsembleStat

GEN_ENS_PROD_REGRID_CONVERT
Specify the value for 'regrid.convert' in the MET configuration file for GenEnsProd.

| *Used by:* GenEnsProd

GEN_ENS_PROD_REGRID_CENSOR_THRESH
Specify the value for 'regrid.censor_thresh' in the MET configuration file for GenEnsProd.

| *Used by:* GenEnsProd

GEN_ENS_PROD_REGRID_CENSOR_VAL
Specify the value for 'regrid.censor_val' in the MET configuration file for GenEnsProd.

| *Used by:* GenEnsProd

GRID_DIAG_REGRID_CONVERT
Specify the value for 'regrid.convert' in the MET configuration file for GridDiag.

| *Used by:* GridDiag

GRID_DIAG_REGRID_CENSOR_THRESH
Specify the value for 'regrid.censor_thresh' in the MET configuration file for GridDiag.

| *Used by:* GridDiag

GRID_DIAG_REGRID_CENSOR_VAL
Specify the value for 'regrid.censor_val' in the MET configuration file for GridDiag.

| *Used by:* GridDiag

GRID_STAT_REGRID_CONVERT
Specify the value for 'regrid.convert' in the MET configuration file for GridStat.

| *Used by:* GridStat

GRID_STAT_REGRID_CENSOR_THRESH
Specify the value for 'regrid.censor_thresh' in the MET configuration file for GridStat.

| *Used by:* GridStat

GRID_STAT_REGRID_CENSOR_VAL
Specify the value for 'regrid.censor_val' in the MET configuration file for GridStat.

| *Used by:* GridStat

MODE_REGRID_CONVERT
Specify the value for 'regrid.convert' in the MET configuration file for MODE.

| *Used by:* MODE

MODE_REGRID_CENSOR_THRESH
Specify the value for 'regrid.censor_thresh' in the MET configuration file for MODE.

| *Used by:* MODE

MODE_REGRID_CENSOR_VAL
Specify the value for 'regrid.censor_val' in the MET configuration file for MODE.

| *Used by:* MODE

MTD_REGRID_CONVERT
Specify the value for 'regrid.convert' in the MET configuration file for MTD.

| *Used by:* MTD

MTD_REGRID_CENSOR_THRESH
Specify the value for 'regrid.censor_thresh' in the MET configuration file for MTD.

| *Used by:* MTD

MTD_REGRID_CENSOR_VAL
Specify the value for 'regrid.censor_val' in the MET configuration file for MTD.

| *Used by:* MTD

POINT2GRID_REGRID_WIDTH
Specify the value for 'regrid.width' in the MET configuration file for Point2Grid.

| *Used by:* Point2Grid

POINT2GRID_REGRID_VLD_THRESH
Specify the value for 'regrid.vld_thresh' in the MET configuration file for Point2Grid.

| *Used by:* Point2Grid

POINT2GRID_REGRID_SHAPE
Specify the value for 'regrid.shape' in the MET configuration file for Point2Grid.

| *Used by:* Point2Grid

POINT2GRID_REGRID_CONVERT
Specify the value for 'regrid.convert' in the MET configuration file for Point2Grid.

| *Used by:* Point2Grid

POINT2GRID_REGRID_CENSOR_THRESH
Specify the value for 'regrid.censor_thresh' in the MET configuration file for Point2Grid.

| *Used by:* Point2Grid

POINT2GRID_REGRID_CENSOR_VAL
Specify the value for 'regrid.censor_val' in the MET configuration file for Point2Grid.

| *Used by:* Point2Grid

POINT_STAT_REGRID_CONVERT
Specify the value for 'regrid.convert' in the MET configuration file for PointStat.

| *Used by:* PointStat

POINT_STAT_REGRID_CENSOR_THRESH
Specify the value for 'regrid.censor_thresh' in the MET configuration file for PointStat.

| *Used by:* PointStat

POINT_STAT_REGRID_CENSOR_VAL
Specify the value for 'regrid.censor_val' in the MET configuration file for PointStat.

| *Used by:* PointStat

SERIES_ANALYSIS_REGRID_CONVERT
Specify the value for 'regrid.convert' in the MET configuration file for SeriesAnalysis.

| *Used by:* SeriesAnalysis

SERIES_ANALYSIS_REGRID_CENSOR_THRESH
Specify the value for 'regrid.censor_thresh' in the MET configuration file for SeriesAnalysis.

| *Used by:* SeriesAnalysis

SERIES_ANALYSIS_REGRID_CENSOR_VAL
Specify the value for 'regrid.censor_val' in the MET configuration file for SeriesAnalysis.

| *Used by:* SeriesAnalysis

TC_RMW_REGRID_CONVERT
Specify the value for 'regrid.convert' in the MET configuration file for TCRMW.

| *Used by:* TCRMW

TC_RMW_REGRID_CENSOR_THRESH
Specify the value for 'regrid.censor_thresh' in the MET configuration file for TCRMW.

| *Used by:* TCRMW

TC_RMW_REGRID_CENSOR_VAL
Specify the value for 'regrid.censor_val' in the MET configuration file for TCRMW.

| *Used by:* TCRMW