Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main_v5.1 GHA - disk space and METviewer version #2561

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

georgemccabe
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

Ran use case groups that use METviewer (met_tool_wrapper:53 and short_range:9) and confirmed that they now run without issue.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Ensure all tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

  • Do these changes introduce new SonarQube findings? [No]

  • Please complete this pull request review by 4/24/2024.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

I checked to make sure all the GHA automated tests work, and as expected, they did. Thanks for making these changes George.

I see that the METplus main_v5.1 branch is now explicitly loading the METviewer main_v5.1 Docker image. While hard-coding that here is fine, we should consider how to elegantly handle inter-component version numbering. Would be nice if we could avoid hard-coding anywhere and just make the automation smart enough.

@JohnHalleyGotway
Copy link
Collaborator

I'm proceeding with the merge to give GHA plenty of time to run and update its output.

@JohnHalleyGotway JohnHalleyGotway merged commit f3def37 into main_v5.1 Apr 23, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants