Update develop-ref after #810 #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, move legend further away from x-axis
… shrank marker sizes
…using Matplotlib's default for resolution.
… indicate whether to use a default resolution or a defined resolution. Resolution value of 0 indicates "allow Matplotlib to determine the resolution". Non-zero value indicates a valid resolution.
revert to 20150301 to match up with available sample data
…ature_803_cycloneplotter_line
Now draw lines between storm waypoints, allow user to modify resolution, and set annotation text size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #804 for issue #803 changed the size of the dots on the output images of met_tool_wrapper/CyclonePlotter/CyclonePlotter.conf. Newly added regression testing (PR #810) caught this difference.
Pull Request Testing
Describe testing already performed for these changes:
We discussed in the METplus meeting (2/18/2021) that the new image is the desired output, so we are updating the reference branch to include these changes.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None needed
Do these changes include sufficient documentation and testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
The reference data volumes will be updated so that future pull requests will use that data to compare output.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone