Feature 718 pcp combine output names #843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Added unit tests to ensure new functions behaved as expected. Modified an existing use case to test that I could add additional output field names and get a successful run. I had to set FCST_PCP_COMBINE_OUTPUT_NAME (1 name for each derivation specified), then I added FCST_PCP_COMBINE_EXTRA_NAMES , FCST_PCP_COMBINE_EXTRA_LEVELS, and FCST_PCP_COMBINE_EXTRA_OUTPUT_NAMES. The extra output names item also needed a name for each derivation specified.
Using the feature branch, test that these changes accomplish what you need to run your use case.
Do these changes include sufficient documentation and testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone