Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 718 pcp combine output names #843

Merged
merged 4 commits into from Mar 16, 2021

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Mar 15, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

Added unit tests to ensure new functions behaved as expected. Modified an existing use case to test that I could add additional output field names and get a successful run. I had to set FCST_PCP_COMBINE_OUTPUT_NAME (1 name for each derivation specified), then I added FCST_PCP_COMBINE_EXTRA_NAMES , FCST_PCP_COMBINE_EXTRA_LEVELS, and FCST_PCP_COMBINE_EXTRA_OUTPUT_NAMES. The extra output names item also needed a name for each derivation specified.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Using the feature branch, test that these changes accomplish what you need to run your use case.

  • Do these changes include sufficient documentation and testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…t fields. Created functions to help with formatting. Allow python embedding in extra fields by filling extra level list with None that be used to skip adding level field info for that field
@georgemccabe georgemccabe added this to the METplus-4.0.0 milestone Mar 15, 2021
@georgemccabe georgemccabe added this to In progress in METplus-4.0.0-beta5 (5/3/21) via automation Mar 15, 2021
@georgemccabe georgemccabe linked an issue Mar 15, 2021 that may be closed by this pull request
21 tasks
@georgemccabe georgemccabe moved this from In progress to Pull Request Review in METplus-4.0.0-beta5 (5/3/21) Mar 15, 2021
@georgemccabe georgemccabe changed the base branch from main_v3.1 to develop March 15, 2021 21:25
Copy link

@LoganDawson-NOAA LoganDawson-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of FCST_PCP_COMBINE_EXTRA_OUTPUT_NAMES in this feature branch works with my use case that has multiple entries set for FCST_PCP_COMBINE_EXTRA_NAMES and FCST_PCP_COMBINE_EXTRA_LEVELS.

@georgemccabe georgemccabe merged commit a741d87 into develop Mar 16, 2021
METplus-4.0.0-beta5 (5/3/21) automation moved this from Pull Request Review to Done Mar 16, 2021
@georgemccabe georgemccabe deleted the feature_718_pcp_combine_output_names branch March 16, 2021 15:41
georgemccabe added a commit that referenced this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Enhance PCPCombine wrapper to be able to process multiple fields in one command
2 participants