Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 857 tc stat met config #861

Closed
wants to merge 1 commit into from

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Mar 30, 2021

Added support for new config variables added to TCStat in dtcenter/MET#1734

Pull Request Testing

  • Describe testing already performed for these changes:

Added unit tests to ensure environment variables used in the wrapped TCStat config file are set properly.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review the changes for typos and ensure that the format of the environment variables values are correct.

Also, in tc_stat_wrapper.py in the calls to the add_met_config function, the metplus_configs argument is a list of accepted METplus config variables in priority order. Make note if any other variations of the name should be supported for ease of use.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-4.0.0 milestone Mar 30, 2021
@georgemccabe georgemccabe added this to In progress in METplus-4.0.0-beta5 (5/3/21) via automation Mar 30, 2021
@georgemccabe georgemccabe linked an issue Mar 30, 2021 that may be closed by this pull request
20 tasks
@georgemccabe georgemccabe moved this from In progress to Pull Request Review in METplus-4.0.0-beta5 (5/3/21) Mar 30, 2021
@georgemccabe georgemccabe changed the base branch from main_v3.1 to develop March 30, 2021 22:43
@georgemccabe
Copy link
Collaborator Author

Closing because this was created to merge into the wrong branch and the automation didn't trigger when I fixed the destination branch.

METplus-4.0.0-beta5 (5/3/21) automation moved this from Pull Request Review to Done Mar 30, 2021
@georgemccabe georgemccabe deleted the feature_857_tc_stat_met_config branch March 31, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update TCStat config options and wrappers to filter data by excluding strings.
1 participant