Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Python implementation of the histogram plot type #322

Closed
3 of 23 tasks
TatianaBurek opened this issue Aug 18, 2021 · 0 comments · Fixed by #348
Closed
3 of 23 tasks

Add the Python implementation of the histogram plot type #322

TatianaBurek opened this issue Aug 18, 2021 · 0 comments · Fixed by #348
Assignees
Labels
reporting: DTC NOAA R2O NOAA Research to Operations DTC Project type: new feature Make it do something new

Comments

@TatianaBurek
Copy link
Collaborator

TatianaBurek commented Aug 18, 2021

Describe the New Feature

*Implement needed classes and add the histogram plots - Rhist, Phist, Relp properties to METviewer.
phist.R_tmpl (Probability Histogram or Histograms of probability integral transform)
relp.R_tmpl (Relative Histogram or Histograms of relative position)
rhist.R_tmpl (Rank Histogram or Histograms of ensemble rank)

Corresponding METcalcpy issue:
dtcenter/METplotpy#141

Acceptance Testing

The histogram plots should be similar to the Rscript plots and include all the functionalities except of those listed in
https://github.com/dtcenter/METplotpy/wiki

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 week of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Probability Histogram
  • Relative Histogram
  • Rank Histogram

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@TatianaBurek TatianaBurek added the type: new feature Make it do something new label Aug 18, 2021
@TatianaBurek TatianaBurek added this to the METviewer 4.1 milestone Aug 18, 2021
@TatianaBurek TatianaBurek added this to To do in METplus-Analysis-4.1.0-beta2 (8/31/21) via automation Aug 18, 2021
@TatianaBurek TatianaBurek self-assigned this Aug 18, 2021
@TatianaBurek TatianaBurek moved this from To do to In progress in METplus-Analysis-4.1.0-beta2 (8/31/21) Aug 18, 2021
@TatianaBurek TatianaBurek added this to To do in METplus-Analysis-4.1.0-beta3 (10/06/21) via automation Sep 7, 2021
@TatianaBurek TatianaBurek linked a pull request Nov 11, 2021 that will close this issue
12 tasks
@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reporting: DTC NOAA R2O NOAA Research to Operations DTC Project type: new feature Make it do something new
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants