New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON output option to fitdump script #45
Conversation
Works great 👍. And fwiw, I'm actively using this patch for a project. |
One query... Is |
For my use case at least, this format made more sense: if isinstance(obj, fitparse.DataMessage):
return {
- "name": obj.name,
- "type": obj.type,
- "data": {
- data.name: data.value for data in obj
- }
+ "type": obj.name,
+ "properties": { data.name: data.value for data in obj } Sample:
|
Other minor things: - Removed non-implemented output formats - Removed the restrction on dumping non-readable formats to stdout - Allow Python to buffer the output for faster execution Fixes #41
33a7ce9
to
ea481db
Compare
@gamb The type of a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a very sane approach to me, @pR0Ps. Thanks for adding this!
Other minor things: - Removed non-implemented output formats - Removed the restrction on dumping non-readable formats to stdout - Allow Python to buffer the output for faster execution Fixes #41
Other minor things:
Fixes #41