Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wijkanders and Linsen shows menu for wrong date. #15

Closed
lindhe opened this issue Aug 18, 2017 · 6 comments
Closed

Wijkanders and Linsen shows menu for wrong date. #15

lindhe opened this issue Aug 18, 2017 · 6 comments
Assignees

Comments

@lindhe
Copy link

lindhe commented Aug 18, 2017

The menu for Linsen (meat dish) is incorrect 2017-08-18.

screenshot from 2017-08-18 13-07-28

photo_2017-08-18_13-15-06

@lindhe
Copy link
Author

lindhe commented Aug 23, 2017

I believe it's incorrect again:

Kycklingfilé med krämig tomat- och rosmarinsås samt parmesanrostad potatis [1]

vs

Lasagna al forno with tomato and basil salad [2]

It was correct again a day or two ago...

@lindhe
Copy link
Author

lindhe commented Aug 23, 2017

I think it's on the wrong day. It's showing Mondays menu for Linsen, and yesterdays menu for Wijkanders.

@lindhe lindhe changed the title Linsen menu is incorrect Wijkanders and Linsen shows menu for wrong date... Aug 23, 2017
@lindhe lindhe changed the title Wijkanders and Linsen shows menu for wrong date... Wijkanders and Linsen shows menu for wrong date. Aug 23, 2017
@Jassob Jassob self-assigned this Aug 23, 2017
@Jassob
Copy link
Contributor

Jassob commented Aug 23, 2017

Thank you for the additional information!

I will see if I can get in touch with whoever is running the https://chalmerskonferens.se/api and request them to fix the Linsen week menu (the day menu is correct).
Fixing the Wijkanders bug should be rather simple... (famous last words)

Jassob added a commit that referenced this issue Aug 25, 2017
@Jassob
Copy link
Contributor

Jassob commented Nov 29, 2017

Linsen is now corrected (it uses the day menu instead of the week menu, so it's not correct after 15 or whenever the system changes to tomorrow's lunches but there is already an issue, #26, about that).

Wijkanders is not correct.

@Jassob
Copy link
Contributor

Jassob commented Nov 29, 2017

@adamse, @Rembane: we don't look for the date when we parse the menu from wijkanders, do we?
If not I really think we should since they include it and that would stop us from showing the lunch for Friday 24/11 on Wednesday 29/11.

@Rembane
Copy link
Contributor

Rembane commented Jan 20, 2019

This is a really old issue, and the code for Wijkander's has been rewritten at least once since the issue was posted, so I hereby close this issue and hope the problem is fixed. If it isn't, please file a new issue.

@Rembane Rembane closed this as completed Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants