Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linsen laddas inte som den ska. #24

Closed
Rembane opened this issue Nov 22, 2017 · 7 comments
Closed

Linsen laddas inte som den ska. #24

Rembane opened this issue Nov 22, 2017 · 7 comments
Assignees
@Rembane @Jassob

Comments

@Rembane
Copy link
Contributor

Rembane commented Nov 22, 2017

Den har typ hälften så många matalternativ som den borde ha.
@Jassob
Copy link
Contributor

Jassob commented Nov 28, 2017

Dessutom har den fel mat på menyn..

Jassob added a commit that referenced this issue Nov 28, 2017
@Jassob
Made Linsen look for menus on the day-menu instead of week menu.
97b2925 
Apparently the RSS for the week menu for Linsen is messed up, so we'll
have to use the day menu instead. This commit fixes that.

However, we will have to solve something for when the rest of the
restaurants switches to tomorrows lunches, as Linsen won't.

Related to issue #24.
@Jassob
Copy link
Contributor

Jassob commented Nov 28, 2017

Linsens API verkar inte funka för deras veckomeny, den bara repeterar måndagens lunch..
Så jag har bytt till dagsmenyn istället för Linsen, varför den bara visar en meny och inte båda är fortfarande lite av ett mysterium dock.

@Jassob
Copy link
Contributor

Jassob commented Nov 28, 2017

Right.. Anledningen till att Linsens meny är konstig jämfört med Kårens (trots att det är samma API) är för att de inte formatterar deras menyer på samma sätt...

@Jassob
Copy link
Contributor

Jassob commented Nov 28, 2017

I kårens fall finns det 5 olika recipeCategories (Classic Kött, Classic Sallad, Fisk, Sallad, Vegetarisk)
och i Linsens fall finns det 1 (Dagens)

@Jassob
Copy link
Contributor

Jassob commented Nov 28, 2017

En lösning på denna och #18 skulle kunna vara att plocka ut alla menyer under varje recipeCategories, jag tror nämligen bara det är den första nu.

Jassob added a commit that referenced this issue Nov 28, 2017
@Jassob
Made mat-chalmers look at all recipes, not only the first.
45dddff 
We only looked at the first recipe for every recipe category, which
made us drop dishes that we in the same recipe category, like the
multiple salad dishes at Classic Salad or the different Linsen dishes.

Should close issue #18 and #24.
@Jassob
Copy link
Contributor

Jassob commented Nov 28, 2017

I think this is solved now, closing the issue.
Please reopen if not satisfied.

@Jassob Jassob closed this as completed Nov 28, 2017
@Rembane
Copy link
Contributor Author

Rembane commented Nov 28, 2017

Det ser bra ut! Vielen dank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rembane Rembane

@Jassob Jassob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rembane @Jassob