Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to fetch image stops fetch of rest of images #13

Closed
dteviot opened this issue Jun 23, 2016 · 3 comments
Closed

Failure to fetch image stops fetch of rest of images #13

dteviot opened this issue Jun 23, 2016 · 3 comments

Comments

@dteviot
Copy link
Owner

dteviot commented Jun 23, 2016

(Note for me.)
Sometimes the attempt to get the high resolution version of an image fails. (e.g. WayBackMachine did not preserve the file.)
In this case, the HTTP exception that is thrown aborts the "fetch all images" operation.

Need an option to say "fetch rest of images on image failure". In which case, use the thumbnail image on the original page and try fetching the rest of the images.

@belldandu
Copy link
Collaborator

belldandu commented Jun 24, 2016

Noticed this too. Depending on the error it should wait a few seconds and try to refetch the image (like when it says service unavailable)

Basically an option like "Attempt to re-fetch images on non 404 errors"
The retry amount could be user specified with a default of 3.

@dteviot
Copy link
Owner Author

dteviot commented Jun 30, 2016

See also #27, at minimum, need to return more useful error message when there is a network failure.

@belldandu belldandu changed the title [Bug] Failure to fetch image stops fetch of rest of images Failure to fetch image stops fetch of rest of images Jul 3, 2016
@belldandu belldandu mentioned this issue Jul 12, 2016
9 tasks
@belldandu belldandu self-assigned this Jul 12, 2016
@dteviot dteviot mentioned this issue Aug 15, 2016
9 tasks
@dteviot
Copy link
Owner Author

dteviot commented Oct 29, 2017

I believe this is fixed by #128

@dteviot dteviot closed this as completed Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants