Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Options button #14

Closed
9 tasks done
dteviot opened this issue Jun 23, 2016 · 18 comments
Closed
9 tasks done

Advanced Options button #14

dteviot opened this issue Jun 23, 2016 · 18 comments

Comments

@dteviot
Copy link
Owner

dteviot commented Jun 23, 2016

(note for self)
Put "Advanced Options" button to right of progress bar.
Button is only visible if Parser advertises that it has advanced options.
If clicked, additional options are put on dialog.
e.g.

  • Fetch Highest Resolution images. (default on)
  • Add List of source URLs to end of ePUB. (default off) No need for this to be visible to most readers. Instead is encoded in <source> elements in contents.opf.
  • URL for cover image
  • Optional stylesheet
  • Include source URL in images (default on)
  • Move "Remove Duplicate Images" to advanced options. (default off)
  • Setting needed for retrying on non 404 error pages (default off) and allowing setting of max retries (default 3) Proved too difficult to implement. Instead, tell user there was problem and give option to retry

Also note

  • Setting need to be saved to localStorage so they can be remembered. between invocations.
  • Also, need to preserve settings when generator updates itself from Chrome store. Seems to do this automatically.
@belldandu belldandu changed the title [Enhancement] Advanced Options button Advanced Options button Jul 3, 2016
@dteviot dteviot self-assigned this Jul 6, 2016
@dteviot
Copy link
Owner Author

dteviot commented Jul 10, 2016

Following have been implemented

  • Optional stylesheet. (Note is not currently saved to local storage.)

@belldandu
Copy link
Collaborator

belldandu commented Jul 12, 2016

Updated this issue to use task lists @dteviot https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments

@belldandu
Copy link
Collaborator

Need to move
Remove Duplicate Images:

Cover from URL:

to advanced options btw as they havent been moved in 0.0.0.11

@belldandu
Copy link
Collaborator

belldandu commented Jul 12, 2016

#22 is part of source url images setting
See also #13 for my comment on adding an option for retrying on non critical errors (such as error pages that aren't 404) and setting a max amount of retries.

@dteviot
Copy link
Owner Author

dteviot commented Jul 25, 2016

@typhoon71 @dreamer2908@toshiya44
Latest commit to https://github.com/dteviot/WebToEpub/tree/AdvancedOptions
I would appreciate it if you'd take it for a test drive. Thanks.

added UserPreferences saved to local storage.

@typhoon71
Copy link

UserPreferences works on chrome, well done.
Not storing the link of images is working (workaround for sumatra nad others).
I'm cleaning up/rebuilding my firefox profile so testing there is out for a while, sorry.

I noticed that I get a white page here: "https://www.baka-tsuki.org/project/index.php?title=Chronicle_Legion:Volume_1"; also, the tab with nation names is cut in two (brutally), with a cut in the middle of a line. Nothing else spotted.

@dteviot
Copy link
Owner Author

dteviot commented Jul 25, 2016

@typhoon71

I'm cleaning up/rebuilding my firefox profile so testing there is out for a while, sorry.
No problem. I'm grateful for whatever you can do.

I noticed that I get a white page here: "https://www.baka-tsuki.org/project/index.php?title=Chronicle_Legion:Volume_1"; also, the tab with nation names is cut in two (brutally), with a cut in the middle of a line. Nothing else spotted.

I wanted to get the preferences in, so that you can try tweaking the settings without me needing to do a rebuild of the extension. Things to try;

  • Allow setting the max height percentage.
  • Use elements, instead of svg . (I think this will work better on newer readers.)

@typhoon71
Copy link

Oh, new options to play with, nice.

Btw: now I have no issue with "https://baka-tsuki.org/project/index.php?title=The_Unexplored_Summon_Blood_Sign:Volume1&printable=yes", which was the one I had issues before (white pages and cut images).

I'm curious on how tabs can be treated when they don't fit on a single page...

@toshiya44
Copy link

Tested the new options and features, I don't see any issue so far. Thanks for the "Fetch highest resolution image" option.
(Tested on Firefox 49.0a2, non-e10 window)

@dteviot
Copy link
Owner Author

dteviot commented Jul 26, 2016

@typhoon71

I'm curious on how tabs can be treated when they don't fit on a single page...

Me too. I didn't think I'd made any changes there. Another item to add to my ToDo list.

@toshiya44

Tested the new options and features, I don't see any issue so far

Thank you.

Thanks for the "Fetch highest resolution image" option.

Actually, it's been fetching the highest resolution image for some time. (That was the second change belldandu made to the code.) I prefer the lower res images. Quicker to download, and significantly smaller epub file. The change was for me, it's really a "fetch reduced resolution images", by turning it off. :)

@toshiya44
Copy link

Yup, low res images looks fine when I'm reading on phone and doesn't take up too much space. It's great :D

@dteviot
Copy link
Owner Author

dteviot commented Nov 4, 2017

@toshiya44 @typhoon71
Advanced Options now has "Include list of fetched URLs"
If checked, adds a "chapter" to end of EPUB that is a table listing the URLs that were collected to make the EPUB.
Can you please try it out and suggest improvements. (Or should I scrap it?)
For your information, the (long term) plan is to support being able to automatically update an epub with new chapters.
i.e. You drop the old EPUB file onto Web to Epub, and it then checks the chapter list for new chapters, and if found, creates a new EPUB, adding the new chapters to it.

@typhoon71
Copy link

I'll test it tomorrow, but I can make some suggestions.

  • does it takes note of the editable forms? Like the title, author, chapters names, filename? It would be a good idea to recover all of those from the loaded epub, so one doesn't have to edit manually again.
  • how does it work with handmade chapter lists? does it just import the existing links, and one can add the new content?
  • instead of a chapter you could add the list into the metadata, or did you make the chater non readable by the reader?
  • bakatsuki: here an automated update would be great: expecially for partially translated volumes, since right now it's all manual work (before they publish the full text)

As of now, I use to do lists of customized links + chapter names... and paste into the urls fetched by web to epub: so NO, don't scrap this idea! It's a good one, really.

@toshiya44
Copy link

For your information, the (long term) plan is to support being able to automatically update an epub with new chapters.

I think it's best left as a comment in a specific file or in a text file inside the epub. Readers don't need to see this.

i.e. You drop the old EPUB file onto Web to Epub, and it then checks the chapter list for new chapters, and if found, creates a new EPUB, adding the new chapters to it.

Will it be able to update an epub as well? For example, redownloading the chapters in an epub based on the list of URLs?

@dteviot
Copy link
Owner Author

dteviot commented Nov 6, 2017

@typhoon71 @toshiya44 I've created #145 specifically for the Automatically Update EPUB feature. What I'd like to know is if you think there's any value in the user being able to see the list of fetched URLs (chapters and images.) Toshiya has explicitly said He doesn't think there's value in readers seeing the information, and I think typhoon implies it with his comment

instead of a chapter you could add the list into the metadata, or did you make the chapter non readable by the reader

i.e. This information should not be visible to user.

@typhoon71
Copy link

Good, the extra data being hidden is good.
Btw, since the goa is to update an epub, I suppose it'll create a new file, so if something goes wrong there's stil lthe old file.

@dteviot
Copy link
Owner Author

dteviot commented Nov 6, 2017

Looks like I should use <source> metadata elements for associating content with original URLs.

    <element name="source">
      <ref name="OPF20.optional-id-attribute"/>
      <ref name="OPF20.optional-xml-lang-attribute"/>
      <ref name="DC.metadata-common-content"/>
    </element>

dteviot added a commit that referenced this issue Nov 7, 2017
Refer: #14
Use <dc:source> elements in content.opf to record where each item in packed EPUB came from.
Note, because of requirement that "id" attributes must be unique I've prefixed the IDs with "id.".
@dteviot
Copy link
Owner Author

dteviot commented Nov 7, 2017

Source URL for each item recorded in elements in contents.opf.

@dteviot dteviot closed this as completed Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants