Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade JSZip library to 3.0.0 #38

Closed
dteviot opened this issue Jul 3, 2016 · 7 comments
Closed

Upgrade JSZip library to 3.0.0 #38

dteviot opened this issue Jul 3, 2016 · 7 comments
Assignees
@dteviot @belldandu
Labels
Priority: High Type: Enhancement

Comments

@dteviot
Copy link
Owner

dteviot commented Jul 3, 2016

From Firefox review of plugin.

Note that old versions of JSZip have known issues which might make extract zip files created with it impossible. Before requesting full review, please upgrade to the latest version.

Also note:

  • Update readme to include the version of JSZip library
  • Use a Git Submodule to bring in the JSZip library, don't include the minified source.
@dteviot dteviot self-assigned this Jul 3, 2016
@belldandu belldandu self-assigned this Jul 12, 2016
belldandu referenced this issue Jul 13, 2016
@belldandu
Use jszip v3 in git submodule
65df35e
@belldandu
Copy link
Collaborator

belldandu commented Jul 13, 2016 •
edited

65df35e Done @dteviot Only thing that needs to be done now is the readme update

@belldandu
Copy link
Collaborator

That and a chrome version bump to 49 in the manifest.json

@belldandu
Copy link
Collaborator

Changed priority due to this effecting the review status of the firefox plugin.

@dteviot
Copy link
Owner Author

dteviot commented Jul 13, 2016

Thanks. Note that items #50 and #49 are going to fail the Firefox review.
I'm working on them currently, but fix may not be easy.

@dteviot
Copy link
Owner Author

dteviot commented Jul 16, 2016

As far as I can tell, once I update the readme this is done.

@dteviot dteviot closed this as completed Jul 16, 2016
@dteviot
Copy link
Owner Author

dteviot commented Jul 16, 2016

@belldandu
And thanks for doing this.

@belldandu
Copy link
Collaborator

@dteviot No problem :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dteviot dteviot

@belldandu belldandu

Labels
Priority: High Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dteviot @belldandu