Errors in opf

[toshiya44]

metadata, manifest, spine and guide sections in the opf has xmlns="" inserted in them.

<metadata xmlns="" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:opf="http://www.idpf.org/2007/opf">
<manifest xmlns="">
<spine xmlns="" toc="ncx">
<guide xmlns="">

Again, calibre can still open the book, but I guess it might be an issue for other lightweight apps.
(using Firefox 49.0a2)

[belldandu]

Can confirm i had these issues even when opening Tests.html in firefox aurora. I had initially ignored them because it didn't seem like they cause any issues however you are right it could potentially cause issues in the more light weight readers.

[belldandu]

Priority changed due to affecting firefox review.

[dteviot]

How To:

• http://stackoverflow.com/questions/31052554/is-it-posible-to-create-a-xml-node-with-prefix-in-javascript
  -http://stackoverflow.com/questions/10995338/how-do-i-add-a-namespace-prefix-to-an-xml-dom-object
• http://stackoverflow.com/questions/12092532/how-to-convert-html-to-valid-xhtml

[dteviot]

@toshiya4, @belldandu, @typhoon71, @dreamer2908

Issues with namespaces should now be fixed in Sonako branch.
I've also tweaked the RoyalRoad parser to delete the "Try the beta reader" advert, if you'd like to give it a go.

[typhoon71]

Tried the new build on RoyalRoad, but this happens (chrome):

I could pack the epub with the previous version (but there was the "Try the beta reader" advert)

Firefox instead does this:

The same happens on BakaTsuki.

[toshiya44]

@dteviot Currently, putting jszip.js or jszip.min.js in "plugin/jszip" gives error. I tried putting the entire thing from Stuck/jszip into that folder and it worked (and the resulting epub didn't have any bugs). I don't get it ;-;

[typhoon71]

Oh, so that was it. It needed the whole thing. Works now.

[belldandu]

@toshiya44 @typhoon71 @dteviot The path is now plugin/jszip/dist/jszip.min.js not plugin/jszip/jszip.min.js

This path is also specified in the edited popup.html and UnitTest.html files.

[dteviot]

D'oh!
Previously, the jszip library was included directly in WebToEpub's git. i.e. the file jszip.min.js was a file checked into GitHub, so when you got the source, it included jszip.
jszip is has been replaced with a submodule. So when you do a Git checkout, it goes to the jszip project and pulls the file from there. Obviously, if you donwload just WebToEpub you no longer get jszip.
I'll update the install from source instructions.

[belldandu]

@dteviot you would think that when downloading the zip file it would include the submodule repo's. Not sure if bug or intentionally like that to prevent issues on githubs end.

[belldandu]

@dteviot We should probably shoot github an email asking whether this behavior is intentional or not.

[dteviot]

@belldandu
I'm pretty sure it's intentional.
wbond/package_control#126 (comment)

[belldandu]

Lovely

[toshiya44]

So, now the solution is to download JSZip from Stuck/jszip, unzip it and copy-paste the dist folder to plugin/jszip.
The namespace issue has been fixed. So I'm closing this.

[dteviot]

@toshiya44

So, now the solution is to download JSZip from Stuck/jszip, unzip it and copy-paste the dist folder to plugin/jszip.

Correct.

The namespace issue has been fixed. So I'm closing this.

Thank you.

[AzSiAz]

As say in the git doc : https://git-scm.com/book/en/v2/Git-Tools-Submodules
In Terminal :

git clone --recursive URL_REPO

Or if downloaded zip

cd webToEpub_Directory
git submodule init
git submodule update

Or as toshiya44 say just download JSZip and unzip

[belldandu]

@AzSiAz Thanks.
@dteviot I think it would be a good idea to add the above to the readme. What about you?

[dteviot]

@belldandu
I'd assumed that anyone who is getting it using Git knows about submodules.
Most Git GUIs will tell users there are submodules and offer to fetch them.

I've already updated the read me with instructions to download jszip if using source download.