Update Appveyor to use Node v7 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR for #99, currently failing due to line endings in JS string yet tests run fine locally, may need to use Node's os.EOL rather than embedding a \n in the string? |
|
@RichyHBM What do these failures have to do with this patch? Why are we seeing failures all of a sudden? |
|
@nfischer I have no idea, as you see my commit doesnt even touch the files... Is it possible to re-test via travis on your end? |
|
@RichyHBM please rebase this off of master |
|
All done! |
|
LGTM. Thanks @RichyHBM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.