Preparse all commands #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #38 is merged, this will add preparsing to almost all commands.
grepandlessuse different packages, so I didn't modify those yet. I skipped preparsing on commands that don't take arguments.I also had it skip the test for
kill, sincekilldoes logging differently than the other commands (it just usesconsole.logI think). Not sure why that is, but I tested it on my commandline and it does seem to actually preparse correctly.If there's a way to check
kill's output, or to add preparsing forgreporless, let me know and I'll modify accordingly.This isn't super useful until variable assignment is added, but I figured I could implement it now anyway.