Upgrade rubyzip #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to pass through options to the various objects and then results in us being able to add known fields to the job when appropriate. Signed-off-by: Christopher Webber <cwebber@chef.io>
There is a [published security vulnerability](rubyzip/rubyzip#315) in rubyzip that requires upgrading it, but the prior version constraint did not allow updating minor versions. This change raises the minimum version of rubyzip to include the vulnerability patch and drops the patch version from the constraint to allow minor version updates.
I'm not sure how any of the specs were passing previously as this was necessary to run them in my development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
There is a published security vulnerability in rubyzip that requires upgrading it, but the prior version constraint did not allow updating minor versions.
This change raises the minimum version of rubyzip to include the vulnerability patch and drops the patch version from the constraint to allow minor version updates.
Please note the parent PR of this change is @cwebberOps' PR, #1, to avoid downgrading the restforce gem dependency.