Issue 9 standalone aietes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtobe
requested changes
Jun 21, 2019
simplified standalone interface by removing some parameters adapted README
ghost
reviewed
Jul 17, 2019
standalone/index.js
Outdated
| const responseFileName = argv.json; | ||
| let jsonResponse; | ||
| if (responseFileName) { | ||
| jsonResponse = JSON.parse(await fs.readFile(responseFileName, 'utf8')); |
There was a problem hiding this comment.
Should we implement something if JSON.parse throws an error because the Json inside the file is not valid?
There was a problem hiding this comment.
That does sound like a good idea. Though I think the only thing we can do is output a (hopefully) helpful error and exit gracefully.
There was a problem hiding this comment.
Come to think of it: what do you mean? Just catch the error that readFile may throw or validate the structure of the JSON read in before passing it to Aietes?
We could do both, like e.g. using this https://www.npmjs.com/package/jsonschema
There was a problem hiding this comment.
I'd suggest doing the validation in a separate PR though.
ghost
self-requested a review
ghost
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not yet final, but would be nice to get some feedback thoughts on how we want to implement the standalone Aietes server and what configuration options we see are "Must Have" in the initial version.