Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting #24

Merged
6 commits merged into from
Jul 6, 2019
Merged

Add linting #24

6 commits merged into from
Jul 6, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 21, 2019

  • Eslint standard configuration (Airbnb and google will not be used yet).
  • Eslint script in package.json.
  • Pre-commit hook not to have unformatted code after each commit. This should avoid commit messages like "make the linter happy again" :)

benjaiser added 2 commits April 29, 2019 22:58
…pre-commit hook setup to be sure that a commit does not produce linting issues
@ghost ghost requested review from dtobe, spik3r and TurgutGenc May 21, 2019 21:08
@dtobe
Copy link
Owner

dtobe commented May 22, 2019

A few minor things.
Personally, I find spaces after function names ugly.
Also, the commas after the last element of a list or object.

@dtobe dtobe added this to In progress in Aietes-JS May 23, 2019
@ghost
Copy link
Author

ghost commented May 24, 2019

A few minor things.
Personally, I find spaces after function names ugly.

Yes. I added a rule for that. Now we should not include spaces after function names.

Also, the commas after the last element of a list or object.

I think we could have pros if we do it like that. Think about writting code and using shortcuts to get line duplicates faster.

/cc @dtobe

- Merge branch 'master' into feature/add-linting
Copy link
Owner

@dtobe dtobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add linting as a build command in the travis-file?

@ghost
Copy link
Author

ghost commented Jul 5, 2019

Do you want to add linting as a build command in the travis-file?

@dtobe It is also an option. I would just prefer to keep it as a pre-commit command and see if we get use to it. This will avoid linting problems during building.

@ghost ghost merged commit b90d00e into master Jul 6, 2019
@ghost ghost moved this from In progress to Done in Aietes-JS Jul 7, 2019
@dtobe dtobe deleted the Feature/add-linting branch August 21, 2019 11:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Aietes-JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants