-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linting #24
Add linting #24
Conversation
ghost
commented
May 21, 2019
•
edited by ghost
Loading
edited by ghost
- Eslint standard configuration (Airbnb and google will not be used yet).
- Eslint script in package.json.
- Pre-commit hook not to have unformatted code after each commit. This should avoid commit messages like "make the linter happy again" :)
…pre-commit hook setup to be sure that a commit does not produce linting issues
A few minor things. |
Yes. I added a rule for that. Now we should not include spaces after function names.
I think we could have pros if we do it like that. Think about writting code and using shortcuts to get line duplicates faster. /cc @dtobe |
- Merge branch 'master' into feature/add-linting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add linting as a build command in the travis-file?
@dtobe It is also an option. I would just prefer to keep it as a pre-commit command and see if we get use to it. This will avoid linting problems during building. |