Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added coverage information #26

Merged
merged 1 commit into from
May 23, 2019
Merged

added coverage information #26

merged 1 commit into from
May 23, 2019

Conversation

dtobe
Copy link
Owner

@dtobe dtobe commented May 23, 2019

includes coveralls lib, yarn scripts, travis action

Note: Coveralls accounts has been linked.

includes coveralls lib, yarn scripts, travis action
@dtobe dtobe requested review from spik3r and a user May 23, 2019 14:24
@dtobe dtobe self-assigned this May 23, 2019
@dtobe dtobe added this to In Review in Aietes-JS May 23, 2019
Copy link
Collaborator

@spik3r spik3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert on coveralls but it looks fine to me.

@dtobe
Copy link
Owner Author

dtobe commented May 23, 2019

Not an expert on coveralls but it looks fine to me.

It seems to work. Note that one of the checks for this PR was coverage. The badge on the README only refers to master.

@dtobe dtobe merged commit f3c3d49 into master May 23, 2019
@dtobe dtobe deleted the feature/add-coverage branch May 23, 2019 16:11
@dtobe dtobe moved this from In Review to Done in Aietes-JS May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Aietes-JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants