Feature/test path variables #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added test suite to assert that parameters can be matched and wildcard expressions are possible
ghost
reviewed
Aug 18, 2019
mock-server.js
Outdated
| if (req.query && Object.keys(req.query).length) { | ||
| logMessage += `Query parameters${buildParameterList(req.query)}`; | ||
| } | ||
| logMessage && console.log(logMessage); |
There was a problem hiding this comment.
Leftover from an earlier draft. Fixed.
logging of parameters should be properly conditional now, also extracted info logging into separate module
ghost
approved these changes
Aug 20, 2019
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experimented with wildcards and parameter definitions in routes.
Motivation was preparation for later validating parameters.