Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect pre-existing RUSTC_BOOTSTRAP setting #206

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Respect pre-existing RUSTC_BOOTSTRAP setting #206

merged 1 commit into from
Dec 30, 2023

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Dec 30, 2023

This avoids overwriting RUSTC_BOOTSTRAP=1 in the case of RUSTC_BOOTSTRAP=some,crates cargo +stable expand, which caused crates which do cargo:rerun-if-env-changed=RUSTC_BOOTSTRAP to recompile unnecessarily.

If the name of the crate currently being expanded is not listed in the pre-existing value of RUSTC_BOOTSTRAP, the expand command will fail.

error: the option `Z` is only accepted on the nightly compiler
help: consider switching to a nightly toolchain: `rustup default nightly`
note: selecting a toolchain with `+toolchain` arguments require a rustup proxy; see <https://rust-lang.github.io/rustup/concepts/index.html>
note: for more information about Rust's stability policy, see <https://doc.rust-lang.org/book/appendix-07-nightly-rust.html#unstable-features>
error: 1 nightly option were parsed

@dtolnay dtolnay merged commit 319bf87 into master Dec 30, 2023
10 checks passed
@dtolnay dtolnay deleted the bootstrap branch December 30, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant