Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit cast from std::size_t to std::streamsize in cxx.cc #1226

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Explicit cast from std::size_t to std::streamsize in cxx.cc #1226

merged 1 commit into from
Jun 15, 2023

Conversation

wravery
Copy link
Contributor

@wravery wravery commented Jun 15, 2023

This is a suggested fix for #1225.

@wravery
Copy link
Contributor Author

wravery commented Jun 15, 2023

When I ran cargo test locally with rustc 1.70, some of the stderr messages were a little different. I rebuilt with TRYBUILD=overwrite and confirmed that the output has changed a little, but the actual errors reported are the same. If the CI build runs into the same mismatch, I'll push another commit with those changes.

dtolnay
dtolnay approved these changes Jun 15, 2023
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit ed1e22e into dtolnay:master Jun 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wravery @dtolnay