Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize shim trait impl blocks over lifetimes #635

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Jan 2, 2021

Part of #608. This updates all Rust generated code when instantiating generic types containing lifetime parameters. This builds on the lifetimes collected by the name resolver in #634.

#[cxx::bridge]
mod ffi {
    extern "C++" {
        type Borrowed<'a>;
                     ^^^^
        fn demo<'b>(s: &'b str) -> UniquePtr<Borrowed<'b>>;
    }
}

turns into:

unsafe impl<'a> UniquePtrTarget for Borrowed<'a> {...}
           ^^^^                             ^^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant