Add swap members + ADL functions #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses dtolnay#58. Adds `swap` members to each of `Slice`, `Str`, `Vec`, `Box`, and `String`. Also adds private friend functions so that Argument Dependent Lookup may function via the `using std::swap;` idiom.
|
One comment @dtolnay - I noticed some members were implemented later in the header, whilst others were implemented in the cpp file. I wasn't clear on the rationale between when to implement in one or the other, so I tried to be consistent with existing code. |
Function templates need to be in a header in C++ for the caller to instantiate. Plain non-template functions go in the source file. |
dtolnay
approved these changes
Jan 2, 2021
|
@dtolnay yep that makes a ton of sense! The holidays have gotten to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58.
Adds
swapmembers to each ofSlice,Str,Vec,Box, andString. Also adds private friend functions so that Argument Dependent Lookup may function via theusing std::swap;idiom.