Decouple C++ exception representation from Rust str #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
added a commit
that referenced
this pull request
Jan 3, 2021
These used to be needed prior to #644.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in order to update rust::Str to match the layout of &str (using the same techniques we do in rust::String to make it match the representation of String in Rust).
Part of the work on #608. Once we allow lifetimes in general, including in structs, it will be possible to have structs containing &str where we can no longer rely on the code generator to reconcile the representation between the Rust side and C++ side the way we currently do for strs in function argument and function return position.