Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require inventory element type to be Sync #42

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Require inventory element type to be Sync #42

merged 2 commits into from
Nov 10, 2021

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Nov 10, 2021

We hand out &'static T references onto arbitrary threads when iterating the inventory, so T: Sync is necessary.

use std::cell::Cell;
use std::thread;

struct Thing {
    cell: Cell<String>,
}

inventory::collect!(Thing);

inventory::submit! {
    Thing {
        cell: Cell::new(String::new()),
    }
}

fn main() {
    thread::spawn(move || {
        let thing = inventory::iter::<Thing>().next().unwrap();
        loop {
            thing.cell.set(".".repeat(40));
        }
    });

    let thing = inventory::iter::<Thing>().next().unwrap();
    loop {
        thing.cell.set(String::new());
        let _ = thing.cell.take().clone();
    }
}
double free or corruption (fasttop)
Aborted (core dumped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant