Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Span::mixed_site, Span::resolved_at, and Span::located_at behind hygiene feature #228

Merged
merged 2 commits into from
May 20, 2020
Merged

Add Span::mixed_site, Span::resolved_at, and Span::located_at behind hygiene feature #228

merged 2 commits into from
May 20, 2020

Commits on May 19, 2020

  1. Add Span::mixed_site() for Rust 1.45+ 

    Fixes dtolnay#210

This was stabilized in Rust in
rust-lang/rust#68716
    @kevinmehall
    kevinmehall committed May 19, 2020
    Configuration menu
    Copy the full SHA
    9e3896d View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Stabilize Span::resolved_at + Span::located_at with fallback 

    On compilers prior to 1.45 where this is not stable, these fall back to
returning the span associated with resolution behavior, since the source
location is only cosmetic. This is a reversal of the previous fallback
implementation, which preserved source location because it does not
track resolution location. The differnce is only observable with
`span_locations` enabled.

These methods were stabilized in Rust in
rust-lang/rust#69041
    @kevinmehall
    kevinmehall committed May 20, 2020
    Configuration menu
    Copy the full SHA
    9b4633b View commit details
    Browse the repository at this point in the history