Stricter parsing of string_continue escapes in cooked string #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports dtolnay/syn#1381 from syn's literal parser to proc-macro2's literal lexer.
Before this PR,
"b\"\\\n\u{a0}\""would parse successfully as a byte string literal token. The trailing backslash would skip over all following Unicode whitespace, including the non-breaking space codepoint. This behavior was incorrect. Trailing backslash is only supposed to skip over ASCII space,\t,\n, and\r\n. Non-ASCII codepoints such as nbsp are not allowed in the representation of a byte string literal.